Skip to content

Commit e7ca702

Browse files
committed
Removed blocknumber struct wrapping since it really isn't necessary
1 parent 6fe45db commit e7ca702

File tree

3 files changed

+7
-12
lines changed

3 files changed

+7
-12
lines changed

block.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ func (c *Client) BlockReward(blockNum int) (rewards BlockRewards, err error) {
1919
return
2020
}
2121

22-
// BlockReward gets closest block number by UNIX timestamp
23-
func (c *Client) BlockNumber(timestamp int64, closest string) (blockNumber BlockNumberFromTimestamp, err error) {
22+
// BlockNumber gets closest block number by UNIX timestamp
23+
func (c *Client) BlockNumber(timestamp int64, closest string) (blockNumber int, err error) {
2424
var result string
2525
param := M{
2626
"timestamp": strconv.Itoa(int(timestamp)),
@@ -34,6 +34,6 @@ func (c *Client) BlockNumber(timestamp int64, closest string) (blockNumber Block
3434
}
3535

3636
blockNum, err := strconv.ParseInt(result, 10, 64)
37-
blockNumber.BlockNumber = int(blockNum)
37+
blockNumber = int(blockNum)
3838
return
3939
}

block_e2e_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,14 @@ func TestClient_BlockNumber(t *testing.T) {
3333
blockNumber, err := api.BlockNumber(1578638524, "before")
3434
noError(t, err, "api.BlockNumber")
3535

36-
if blockNumber.BlockNumber != ans_before {
37-
t.Errorf(`api.BlockNumber(1578638524, "before") not working, got %d, want %d`, blockNumber.BlockNumber, ans_before)
36+
if blockNumber != ans_before {
37+
t.Errorf(`api.BlockNumber(1578638524, "before") not working, got %d, want %d`, blockNumber, ans_before)
3838
}
3939

4040
blockNumber, err = api.BlockNumber(1578638524, "after")
4141
noError(t, err, "api.BlockNumber")
4242

43-
if blockNumber.BlockNumber != ans_after {
44-
t.Errorf(`api.BlockNumber(1578638524,"after") not working, got %d, want %d`, blockNumber.BlockNumber, ans_after)
43+
if blockNumber != ans_after {
44+
t.Errorf(`api.BlockNumber(1578638524,"after") not working, got %d, want %d`, blockNumber, ans_after)
4545
}
4646
}

response.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,6 @@ type BlockRewards struct {
129129
UncleInclusionReward *BigInt `json:"uncleInclusionReward"`
130130
}
131131

132-
// BlockNumberFromTimestamp holds info from query for block by UNIX timestamp
133-
type BlockNumberFromTimestamp struct {
134-
BlockNumber int
135-
}
136-
137132
// LatestPrice holds info from query for latest ether price
138133
type LatestPrice struct {
139134
ETHBTC float64 `json:"ethbtc,string"`

0 commit comments

Comments
 (0)