Skip to content

Commit 47a2daf

Browse files
Mehdi ChamoumaMehdi Chamouma
authored andcommitted
Merge remote-tracking branch 'upstream/master'
Conflicts: dist/angular-timer.js dist/angular-timer.min.js
2 parents 07bbada + 6d59153 commit 47a2daf

File tree

7 files changed

+16
-7
lines changed

7 files changed

+16
-7
lines changed

app/js/timer.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,9 @@ angular.module('timer', [])
8686
};
8787

8888
$scope.stop = $scope.pause = $element[0].stop = $element[0].pause = function () {
89+
var timeoutId = $scope.timeoutId;
8990
$scope.clear();
90-
$scope.$emit('timer-stopped', {millis: $scope.millis, seconds: $scope.seconds, minutes: $scope.minutes, hours: $scope.hours, days: $scope.days});
91+
$scope.$emit('timer-stopped', {timeoutId: timeoutId, millis: $scope.millis, seconds: $scope.seconds, minutes: $scope.minutes, hours: $scope.hours, days: $scope.days});
9192
};
9293

9394
$scope.clear = $element[0].clear = function () {

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"author": "Siddique Hameed",
33
"name": "angular-timer",
4-
"version": "1.1.0",
4+
"version": "1.1.1",
55
"homepage": "https://github.com/siddii/angular-timer",
66
"description": "Angular-Timer : A simple AngularJS directive demonstrating re-usability & interoperability",
77
"repository": {

dist/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
##Change Log
22

3+
###Version 1.1.1
4+
* Fix for https://github.com/siddii/angular-timer/issues/73
5+
36
###Version 1.1.0
47
* Plural/singular units. PR - https://github.com/siddii/angular-timer/pull/54
58
* IE8 support. PR - https://github.com/siddii/angular-timer/pull/62

dist/angular-timer.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* angular-timer - v1.1.0 - 2014-05-17 1:35 AM
2+
* angular-timer - v1.1.1 - 2014-05-17 3:24 AM
33
* https://github.com/siddii/angular-timer
44
*
55
* Copyright (c) 2014 Siddique Hameed
@@ -93,8 +93,9 @@ angular.module('timer', [])
9393
};
9494

9595
$scope.stop = $scope.pause = $element[0].stop = $element[0].pause = function () {
96+
var timeoutId = $scope.timeoutId;
9697
$scope.clear();
97-
$scope.$emit('timer-stopped', {millis: $scope.millis, seconds: $scope.seconds, minutes: $scope.minutes, hours: $scope.hours, days: $scope.days});
98+
$scope.$emit('timer-stopped', {timeoutId: timeoutId, millis: $scope.millis, seconds: $scope.seconds, minutes: $scope.minutes, hours: $scope.hours, days: $scope.days});
9899
};
99100

100101
$scope.clear = $element[0].clear = function () {

dist/angular-timer.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/angularjs-multiple-timers.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@
1818
$scope.$broadcast('timer-stop');
1919
$scope.timerRunning = false;
2020
};
21+
22+
$scope.$on('timer-stopped', function (event, args) {
23+
console.log('timer-stopped args = ', args);
24+
});
2125
}
2226
MyAppController.$inject = ['$scope'];
2327
</script>

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"author": "Siddique Hameed",
33
"name": "angular-timer",
4-
"version": "1.1.0",
4+
"version": "1.1.1",
55
"homepage": "https://github.com/siddii/angular-timer",
66
"licenses": {
77
"type": "MIT",

0 commit comments

Comments
 (0)