Skip to content

Commit 88403b0

Browse files
committed
Only fail the Android Resolver in a more specific case
The Android Resolver should only fail to warn the user about Gradle project change in Unity 2019.3+ if 1. In Unity 2019.3+ 2. The project is using mainTemplate.gradle 3. gradlTemplate.properties is not enabled 4. Jetifier is enabled 5. "Patch gradleTemplate.properties" is enabled. The 2nd condition was not checked. As a result, it can fail even the user is not using mainTemplate.gradle. Change-Id: Ie658ef1ced520ee8c5ccecb1d9f1cc8b05e6180b
1 parent 81f3202 commit 88403b0

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

source/AndroidResolver/src/PlayServicesResolver.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1916,15 +1916,18 @@ private static void ResolveUnsafe(Action<bool> resolutionComplete,
19161916
Google.VersionHandler.GetUnityVersionMajorMinor() >= 2019.3f &&
19171917
SettingsDialogObj.UseJetifier &&
19181918
SettingsDialogObj.PatchPropertiesTemplateGradle &&
1919+
GradleTemplateEnabled &&
19191920
!GradlePropertiesTemplateEnabled) {
19201921
lastError = String.Format(
1921-
"Resolution failed because EDM4u could not enable Jetifier " +
1922+
"Resolution failed because EDM4U could not enable Jetifier " +
19221923
"in Unity {0} without Custom Gradle Properties Template. " +
19231924
"Please enable 'Custom Gradle Properties Template' found under " +
19241925
"'Player Settings > Settings for Android -> Publishing Settings' menu. " +
19251926
"Due to changes in Gradle project generated by Unity 2019.3 and "+
19261927
"above, our recommended way of enabling Jetifier is by injecting "+
1927-
"properties to Assets/Plugins/Android/gradleTemplate.properties.",
1928+
"properties to Assets/Plugins/Android/gradleTemplate.properties.\n" +
1929+
"If you like to patch this yourself, simply disable 'Patch " +
1930+
"gradleTemplate.properties' in Android Resolver settings.",
19281931
Google.VersionHandler.GetUnityVersionMajorMinor()
19291932
);
19301933
return false;

0 commit comments

Comments
 (0)