Skip to content

Commit d419ab7

Browse files
committed
moved variable to loop
1 parent 5cd1b05 commit d419ab7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

source/AndroidResolver/src/PlayServicesResolver.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2203,10 +2203,10 @@ internal static IList<string> GradleDependenciesLines(
22032203
// we want to activate only the highest version but still include the
22042204
// other versions as commented out dependency lines.
22052205
var dependenciesMaxVersions = new Dictionary<string, Dependency>();
2206-
Dependency dependencyMaxVersion;
22072206
// Maintain a set of packages which we want to comment out.
22082207
HashSet<string> packageSpecStringsToComment = new HashSet<string>();
22092208
foreach( var dependency in dependencies) {
2209+
Dependency dependencyMaxVersion;
22102210
if (dependenciesMaxVersions.TryGetValue(dependency.VersionlessKey, out dependencyMaxVersion)){
22112211
if(versionComparer.Compare(dependency.Version, dependencyMaxVersion.Version) < 0) {
22122212
dependenciesMaxVersions[dependency.VersionlessKey] = dependency;

source/AndroidResolver/test/AndroidResolverIntegrationTestsUnityProject/ExpectedArtifacts/NoExport/GradleTemplateDuplicatePackages/mainTemplate.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ dependencies {
5050
// compile 'com.google.android.gms:play-services-base:12.0.1' // Assets/ExternalDependencyManager/Editor/TestAdditionalDuplicateDependencies.xml:6
5151
// compile 'com.google.android.gms:play-services-base:15.0.1' // Assets/ExternalDependencyManager/Editor/TestAdditionalDependencies.xml:3
5252
compile 'com.google.android.gms:play-services-base:18.0.1' // Assets/ExternalDependencyManager/Editor/TestAdditionalDuplicateDependencies.xml:4
53-
// compile 'com.google.firebase:firebase-app-unity:5.+' // Assets/ExternalDependencyManager/Editor/TestAdditionalDuplicateDependencies.xml:6
53+
// compile 'com.google.firebase:firebase-app-unity:5.+' // Assets/ExternalDependencyManager/Editor/TestAdditionalDuplicateDependencies.xml:8
5454
compile 'com.google.firebase:firebase-app-unity:5.1.1' // Assets/ExternalDependencyManager/Editor/TestDependencies.xml:10
5555
compile 'com.google.firebase:firebase-common:16.0.0' // Google.AndroidResolverIntegrationTests.SetupDependencies
5656
compile 'org.test.psr:classifier:1.0.1:foo@aar' // Assets/ExternalDependencyManager/Editor/TestDependencies.xml:12

0 commit comments

Comments
 (0)