Skip to content

Commit cd526fe

Browse files
author
Francesco Rodriguez
committed
fix scaffold controller generator tests
1 parent a3c29b7 commit cd526fe

File tree

1 file changed

+12
-16
lines changed

1 file changed

+12
-16
lines changed

railties/test/generators/scaffold_generator_test.rb

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,13 @@ def test_scaffold_on_invoke
3030
assert_match(/@product_lines = ProductLine\.all/, m)
3131
end
3232

33-
assert_instance_method :show, content do |m|
34-
assert_match(/@product_line = ProductLine\.find\(params\[:id\]\)/, m)
35-
end
33+
assert_instance_method :show, content
3634

3735
assert_instance_method :new, content do |m|
3836
assert_match(/@product_line = ProductLine\.new/, m)
3937
end
4038

41-
assert_instance_method :edit, content do |m|
42-
assert_match(/@product_line = ProductLine\.find\(params\[:id\]\)/, m)
43-
end
39+
assert_instance_method :edit, content
4440

4541
assert_instance_method :create, content do |m|
4642
assert_match(/@product_line = ProductLine\.new\(product_line_params\)/, m)
@@ -49,15 +45,17 @@ def test_scaffold_on_invoke
4945
end
5046

5147
assert_instance_method :update, content do |m|
52-
assert_match(/@product_line = ProductLine\.find\(params\[:id\]\)/, m)
5348
assert_match(/@product_line\.update_attributes\(product_line_params\)/, m)
5449
assert_match(/@product_line\.errors/, m)
5550
end
5651

5752
assert_instance_method :destroy, content do |m|
58-
assert_match(/@product_line = ProductLine\.find\(params\[:id\]\)/, m)
5953
assert_match(/@product_line\.destroy/, m)
6054
end
55+
56+
assert_instance_method :set_product_line, content do |m|
57+
assert_match(/@product_line = ProductLine\.find\(params\[:id\]\)/, m)
58+
end
6159
end
6260

6361
assert_file "test/controllers/product_lines_controller_test.rb" do |test|
@@ -149,17 +147,13 @@ def test_scaffold_with_namespace_on_invoke
149147
assert_match(/@admin_roles = Admin::Role\.all/, m)
150148
end
151149

152-
assert_instance_method :show, content do |m|
153-
assert_match(/@admin_role = Admin::Role\.find\(params\[:id\]\)/, m)
154-
end
150+
assert_instance_method :show, content
155151

156152
assert_instance_method :new, content do |m|
157153
assert_match(/@admin_role = Admin::Role\.new/, m)
158154
end
159155

160-
assert_instance_method :edit, content do |m|
161-
assert_match(/@admin_role = Admin::Role\.find\(params\[:id\]\)/, m)
162-
end
156+
assert_instance_method :edit, content
163157

164158
assert_instance_method :create, content do |m|
165159
assert_match(/@admin_role = Admin::Role\.new\(admin_role_params\)/, m)
@@ -168,15 +162,17 @@ def test_scaffold_with_namespace_on_invoke
168162
end
169163

170164
assert_instance_method :update, content do |m|
171-
assert_match(/@admin_role = Admin::Role\.find\(params\[:id\]\)/, m)
172165
assert_match(/@admin_role\.update_attributes\(admin_role_params\)/, m)
173166
assert_match(/@admin_role\.errors/, m)
174167
end
175168

176169
assert_instance_method :destroy, content do |m|
177-
assert_match(/@admin_role = Admin::Role\.find\(params\[:id\]\)/, m)
178170
assert_match(/@admin_role\.destroy/, m)
179171
end
172+
173+
assert_instance_method :set_admin_role, content do |m|
174+
assert_match(/@admin_role = Admin::Role\.find\(params\[:id\]\)/, m)
175+
end
180176
end
181177

182178
assert_file "test/controllers/admin/roles_controller_test.rb",

0 commit comments

Comments
 (0)