Skip to content

Commit fb74394

Browse files
committed
Remove unneeded comments about feature support on the adapters
These comments will likely be outdated with time and doesn't include any information that can't be found in the adapters
1 parent baf62e5 commit fb74394

File tree

1 file changed

+9
-20
lines changed

1 file changed

+9
-20
lines changed

activerecord/lib/active_record/connection_adapters/abstract_adapter.rb

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -146,28 +146,24 @@ def adapter_name
146146
'Abstract'
147147
end
148148

149-
# Does this adapter support migrations? Backend specific, as the
150-
# abstract adapter always returns +false+.
149+
# Does this adapter support migrations?
151150
def supports_migrations?
152151
false
153152
end
154153

155154
# Can this adapter determine the primary key for tables not attached
156-
# to an Active Record class, such as join tables? Backend specific, as
157-
# the abstract adapter always returns +false+.
155+
# to an Active Record class, such as join tables?
158156
def supports_primary_key?
159157
false
160158
end
161159

162-
# Does this adapter support using DISTINCT within COUNT? This is +true+
163-
# for all adapters except sqlite.
160+
# Does this adapter support using DISTINCT within COUNT?
164161
def supports_count_distinct?
165162
true
166163
end
167164

168165
# Does this adapter support DDL rollbacks in transactions? That is, would
169-
# CREATE TABLE or ALTER TABLE get rolled back by a transaction? PostgreSQL,
170-
# SQL Server, and others support this. MySQL and others do not.
166+
# CREATE TABLE or ALTER TABLE get rolled back by a transaction?
171167
def supports_ddl_transactions?
172168
false
173169
end
@@ -176,16 +172,14 @@ def supports_bulk_alter?
176172
false
177173
end
178174

179-
# Does this adapter support savepoints? PostgreSQL and MySQL do,
180-
# SQLite < 3.6.8 does not.
175+
# Does this adapter support savepoints?
181176
def supports_savepoints?
182177
false
183178
end
184179

185180
# Should primary key values be selected from their corresponding
186181
# sequence before the insert statement? If true, next_sequence_value
187182
# is called before each insert to set the record's primary key.
188-
# This is false for all adapters but Firebird.
189183
def prefetch_primary_key?(table_name = nil)
190184
false
191185
end
@@ -200,8 +194,7 @@ def supports_partial_index?
200194
false
201195
end
202196

203-
# Does this adapter support explain? As of this writing sqlite3,
204-
# mysql2, and postgresql are the only ones that do.
197+
# Does this adapter support explain?
205198
def supports_explain?
206199
false
207200
end
@@ -211,14 +204,13 @@ def supports_transaction_isolation?
211204
false
212205
end
213206

214-
# Does this adapter support database extensions? As of this writing only
215-
# postgresql does.
207+
# Does this adapter support database extensions?
216208
def supports_extensions?
217209
false
218210
end
219211

220212
# Does this adapter support creating indexes in the same statement as
221-
# creating the table? As of this writing, only mysql does.
213+
# creating the table?
222214
def supports_indexes_in_create?
223215
false
224216
end
@@ -231,14 +223,12 @@ def disable_extension(name)
231223
def enable_extension(name)
232224
end
233225

234-
# A list of extensions, to be filled in by adapters that support them. At
235-
# the moment only postgresql does.
226+
# A list of extensions, to be filled in by adapters that support them.
236227
def extensions
237228
[]
238229
end
239230

240231
# A list of index algorithms, to be filled by adapters that support them.
241-
# MySQL and PostgreSQL have support for them right now.
242232
def index_algorithms
243233
{}
244234
end
@@ -299,7 +289,6 @@ def clear_cache!
299289
end
300290

301291
# Returns true if its required to reload the connection between requests for development mode.
302-
# This is not the case for Ruby/MySQL and it's not necessary for any adapters except SQLite.
303292
def requires_reloading?
304293
false
305294
end

0 commit comments

Comments
 (0)