Show description changes in Maniphest

Summary:
When a task description is updated, there's currently no way to see the change.
Build an "expanded summary" mode for transactions that shows description change
details. Also include changes in the email.

Test Plan:
Changed task descriptions, clicked "show details", read email.

Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
CC: anjali, aran, epriestley
Differential Revision: 320

Author: epriestley

externals/javelin

@@ -179,16 +179,6 @@
     ),
     'disk' => '/rsrc/css/application/differential/revision-comment-list.css',
   ),
-  0 =>
-  array(
-    'uri' => '/res/39de799e/rsrc/js/javelin/docs/Base.js',
-    'type' => 'js',
-    'requires' =>
-    array(
-      0 => 'javelin-install',
-    ),
-    'disk' => '/rsrc/js/javelin/docs/Base.js',
-  ),
   'differential-revision-detail-css' =>
   array(
     'uri' => '/res/ea9de420/rsrc/css/application/differential/revision-detail.css',
@@ -225,15 +215,6 @@
     ),
     'disk' => '/rsrc/css/application/diffusion/commit-view.css',
   ),
-  'diffusion-source-css' =>
-  array(
-    'uri' => '/res/415aad1a/rsrc/css/application/diffusion/diffusion-source.css',
-    'type' => 'css',
-    'requires' =>
-    array(
-    ),
-    'disk' => '/rsrc/css/application/diffusion/diffusion-source.css',
-  ),
   'herald-css' =>
   array(
     'uri' => '/res/5051f3ab/rsrc/css/application/herald/herald.css',
@@ -475,6 +456,19 @@
     ),
     'disk' => '/rsrc/js/application/maniphest/behavior-transaction-controls.js',
   ),
+  'javelin-behavior-maniphest-transaction-expand' =>
+  array(
+    'uri' => '/res/966410de/rsrc/js/application/maniphest/behavior-transaction-expand.js',
+    'type' => 'js',
+    'requires' =>
+    array(
+      0 => 'javelin-behavior',
+      1 => 'javelin-dom',
+      2 => 'javelin-workflow',
+      3 => 'javelin-stratcom',
+    ),
+    'disk' => '/rsrc/js/application/maniphest/behavior-transaction-expand.js',
+  ),
   'javelin-behavior-maniphest-transaction-preview' =>
   array(
     'uri' => '/res/44e86555/rsrc/js/application/maniphest/behavior-transaction-preview.js',
@@ -539,6 +533,16 @@
     ),
     'disk' => '/rsrc/js/javelin/lib/DOM.js',
   ),
+  0 =>
+  array(
+    'uri' => '/res/39de799e/rsrc/js/javelin/docs/Base.js',
+    'type' => 'js',
+    'requires' =>
+    array(
+      0 => 'javelin-install',
+    ),
+    'disk' => '/rsrc/js/javelin/docs/Base.js',
+  ),
   'javelin-event' =>
   array(
     'uri' => '/res/25c7c9e8/rsrc/js/javelin/core/Event.js',
@@ -562,7 +566,7 @@
   ),
   'javelin-json' =>
   array(
-    'uri' => '/res/315c8b24/rsrc/js/javelin/lib/JSON.js',
+    'uri' => '/res/1c4e3f6a/rsrc/js/javelin/lib/JSON.js',
     'type' => 'js',
     'requires' =>
     array(
@@ -607,7 +611,7 @@
   ),
   'javelin-stratcom' =>
   array(
-    'uri' => '/res/d3f4599a/rsrc/js/javelin/core/Stratcom.js',
+    'uri' => '/res/9e7eb62b/rsrc/js/javelin/core/Stratcom.js',
     'type' => 'js',
     'requires' =>
     array(
@@ -764,7 +768,7 @@
   ),
   'maniphest-transaction-detail-css' =>
   array(
-    'uri' => '/res/8e196c52/rsrc/css/application/maniphest/transaction-detail.css',
+    'uri' => '/res/0a35f731/rsrc/css/application/maniphest/transaction-detail.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -998,7 +1002,7 @@
       'uri' => '/res/pkg/33f413ef/typeahead.pkg.js',
       'type' => 'js',
     ),
-    '7d23deb1' =>
+    'ce1d51a9' =>
     array (
       'name' => 'javelin.pkg.js',
       'symbols' =>
@@ -1014,7 +1018,7 @@
         8 => 'javelin-json',
         9 => 'javelin-uri',
       ),
-      'uri' => '/res/pkg/7d23deb1/javelin.pkg.js',
+      'uri' => '/res/pkg/ce1d51a9/javelin.pkg.js',
       'type' => 'js',
     ),
     'ed383f69' =>
@@ -1052,30 +1056,30 @@
     'differential-revision-history-css' => '314934dc',
     'differential-table-of-contents-css' => '314934dc',
     'diffusion-commit-view-css' => '03ef179e',
-    'javelin-behavior' => '7d23deb1',
+    'javelin-behavior' => 'ce1d51a9',
     'javelin-behavior-aphront-basic-tokenizer' => '33f413ef',
     'javelin-behavior-differential-diff-radios' => 'ed383f69',
     'javelin-behavior-differential-edit-inline-comments' => 'ed383f69',
     'javelin-behavior-differential-feedback-preview' => 'ed383f69',
     'javelin-behavior-differential-populate' => 'ed383f69',
     'javelin-behavior-differential-show-more' => 'ed383f69',
     'javelin-behavior-workflow' => '122a6b6d',
-    'javelin-dom' => '7d23deb1',
-    'javelin-event' => '7d23deb1',
-    'javelin-install' => '7d23deb1',
-    'javelin-json' => '7d23deb1',
+    'javelin-dom' => 'ce1d51a9',
+    'javelin-event' => 'ce1d51a9',
+    'javelin-install' => 'ce1d51a9',
+    'javelin-json' => 'ce1d51a9',
     'javelin-mask' => '122a6b6d',
-    'javelin-request' => '7d23deb1',
-    'javelin-stratcom' => '7d23deb1',
+    'javelin-request' => 'ce1d51a9',
+    'javelin-stratcom' => 'ce1d51a9',
     'javelin-tokenizer' => '33f413ef',
     'javelin-typeahead' => '33f413ef',
     'javelin-typeahead-normalizer' => '33f413ef',
     'javelin-typeahead-ondemand-source' => '33f413ef',
     'javelin-typeahead-preloaded-source' => '33f413ef',
     'javelin-typeahead-source' => '33f413ef',
-    'javelin-uri' => '7d23deb1',
-    'javelin-util' => '7d23deb1',
-    'javelin-vector' => '7d23deb1',
+    'javelin-uri' => 'ce1d51a9',
+    'javelin-util' => 'ce1d51a9',
+    'javelin-vector' => 'ce1d51a9',
     'javelin-workflow' => '122a6b6d',
     'phabricator-core-buttons-css' => '1ef6c6f9',
     'phabricator-core-css' => '1ef6c6f9',

src/__celerity_resource_map__.php

@@ -250,6 +250,7 @@
     'ManiphestDAO' => 'applications/maniphest/storage/base',
     'ManiphestReplyHandler' => 'applications/maniphest/replyhandler',
     'ManiphestTask' => 'applications/maniphest/storage/task',
+    'ManiphestTaskDescriptionChangeController' => 'applications/maniphest/controller/descriptionchange',
     'ManiphestTaskDetailController' => 'applications/maniphest/controller/taskdetail',
     'ManiphestTaskEditController' => 'applications/maniphest/controller/taskedit',
     'ManiphestTaskListController' => 'applications/maniphest/controller/tasklist',
@@ -692,6 +693,7 @@
     'ManiphestDAO' => 'PhabricatorLiskDAO',
     'ManiphestReplyHandler' => 'PhabricatorMailReplyHandler',
     'ManiphestTask' => 'ManiphestDAO',
+    'ManiphestTaskDescriptionChangeController' => 'ManiphestController',
     'ManiphestTaskDetailController' => 'ManiphestController',
     'ManiphestTaskEditController' => 'ManiphestController',
     'ManiphestTaskListController' => 'ManiphestController',

src/__phutil_library_map__.php

@@ -157,6 +157,8 @@ public function getURIMap() {
         'task/' => array(
           'create/$' => 'ManiphestTaskEditController',
           'edit/(?P<id>\d+)/$' => 'ManiphestTaskEditController',
+          'descriptionchange/(?P<id>\d+)/$' =>
+            'ManiphestTaskDescriptionChangeController',
         ),
         'transaction/' => array(
           'save/' => 'ManiphestTransactionSaveController',

src/aphront/default/configuration/AphrontDefaultApplicationConfiguration.php

@@ -14,7 +14,6 @@
 phutil_require_module('phabricator', 'view/layout/panel');
 
 phutil_require_module('phutil', 'markup');
-phutil_require_module('phutil', 'parser/uri');
 phutil_require_module('phutil', 'utils');
 
 

src/applications/diffusion/controller/history/__init__.php

@@ -0,0 +1,60 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+class ManiphestTaskDescriptionChangeController extends ManiphestController {
+
+  private $transactionID;
+
+  public function willProcessRequest(array $data) {
+    $this->transactionID = $data['id'];
+  }
+
+  public function processRequest() {
+
+    $request = $this->getRequest();
+    $user = $request->getUser();
+
+    $transaction = id(new ManiphestTransaction())->load($this->transactionID);
+    if (!$transaction) {
+      return new Aphront404Response();
+    }
+
+    $transactions = array($transaction);
+
+    $phids = array();
+    foreach ($transactions as $transaction) {
+      foreach ($transaction->extractPHIDs() as $phid) {
+        $phids[$phid] = $phid;
+      }
+    }
+    $handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
+
+    $factory = new DifferentialMarkupEngineFactory();
+    $engine = $factory->newDifferentialCommentMarkupEngine();
+
+    $view = new ManiphestTransactionDetailView();
+    $view->setTransactionGroup($transactions);
+    $view->setHandles($handles);
+    $view->setMarkupEngine($engine);
+    $view->setRenderSummaryOnly(true);
+    $view->setRenderFullSummary(true);
+
+    return id(new AphrontAjaxResponse())->setContent($view->render());
+  }
+
+}

src/applications/maniphest/controller/descriptionchange/ManiphestTaskDescriptionChangeController.php

@@ -0,0 +1,20 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'aphront/response/404');
+phutil_require_module('phabricator', 'aphront/response/ajax');
+phutil_require_module('phabricator', 'applications/differential/parser/markup');
+phutil_require_module('phabricator', 'applications/maniphest/controller/base');
+phutil_require_module('phabricator', 'applications/maniphest/storage/transaction');
+phutil_require_module('phabricator', 'applications/maniphest/view/transactiondetail');
+phutil_require_module('phabricator', 'applications/phid/handle/data');
+
+phutil_require_module('phutil', 'utils');
+
+
+phutil_require_source('ManiphestTaskDescriptionChangeController.php');