RandomAccessBody.transferTo count is actually unused (Long.MAX_VALUE)

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/Body.java

@@ -36,6 +36,7 @@ public interface Body extends Closeable {
      * @return The non-negative number of bytes actually read or {@code -1} if the body has been read completely.
      * @throws IOException If the chunk could not be read.
      */
+    // FIXME introduce a visitor pattern so that Netty can pass a pooled buffer
     long read(ByteBuffer buffer) throws IOException;
 
     /**

api/src/main/java/org/asynchttpclient/RandomAccessBody.java

@@ -26,13 +26,11 @@ public interface RandomAccessBody extends Body {
      * 
      * @param position
      *            The zero-based byte index from which to start the transfer, must not be negative.
-     * @param count
-     *            The maximum number of bytes to transfer, must not be negative.
      * @param target
      *            The destination channel to transfer the body chunk to, must not be {@code null}.
      * @return The non-negative number of bytes actually transferred.
      * @throws IOException
      *             If the body chunk could not be transferred.
      */
-    long transferTo(long position, long count, WritableByteChannel target) throws IOException;
+    long transferTo(long position, WritableByteChannel target) throws IOException;
 }

api/src/main/java/org/asynchttpclient/generators/FileBodyGenerator.java

@@ -25,6 +25,7 @@
 /**
  * Creates a request body from the contents of a file.
  */
+//Not used by Netty
 public class FileBodyGenerator implements BodyGenerator {
 
     private final File file;
@@ -89,11 +90,8 @@ public long read(ByteBuffer buffer) throws IOException {
             return channel.read(buffer);
         }
 
-        public long transferTo(long position, long count, WritableByteChannel target) throws IOException {
-            if (count > length) {
-                count = length;
-            }
-            return channel.transferTo(position, count, target);
+        public long transferTo(long position, WritableByteChannel target) throws IOException {
+            return channel.transferTo(position, length, target);
         }
 
         public void close() throws IOException {

api/src/main/java/org/asynchttpclient/multipart/MultipartBody.java

@@ -69,7 +69,7 @@ public String getContentType() {
     }
 
     // RandomAccessBody API, suited for HTTP but not for HTTPS
-    public long transferTo(long position, long count, WritableByteChannel target) throws IOException {
+    public long transferTo(long position, WritableByteChannel target) throws IOException {
 
         long overallLength = 0;