closeSilently

Author: Stephane Landelle

api/src/main/java/org/asynchttpclient/Body.java

@@ -38,11 +38,4 @@ public interface Body extends Closeable {
      */
     // FIXME introduce a visitor pattern so that Netty can pass a pooled buffer
     long read(ByteBuffer buffer) throws IOException;
-
-    /**
-     * Releases any resources associated with this body.
-     *
-     * @throws IOException
-     */
-    void close() throws IOException;
 }

api/src/main/java/org/asynchttpclient/BodyConsumer.java

@@ -25,15 +25,8 @@ public interface BodyConsumer extends Closeable {
     /**
      * Consume the received bytes.
      *
-     * @param byteBuffer a {@link ByteBuffer} represntation of the response's chunk.
+     * @param byteBuffer a {@link ByteBuffer} representation of the response's chunk.
      * @throws IOException
      */
     void consume(ByteBuffer byteBuffer) throws IOException;
-
-    /**
-     * Invoked when all the response bytes has been processed.
-     *
-     * @throws IOException
-     */
-    void close() throws IOException;
 }

api/src/main/java/org/asynchttpclient/SimpleAsyncHttpClient.java

@@ -12,17 +12,7 @@
  */
 package org.asynchttpclient;
 
-import org.asynchttpclient.cookie.Cookie;
-import org.asynchttpclient.multipart.Part;
-import org.asynchttpclient.resumable.ResumableAsyncHandler;
-import org.asynchttpclient.resumable.ResumableIOExceptionFilter;
-import org.asynchttpclient.simple.HeaderMap;
-import org.asynchttpclient.simple.SimpleAHCTransferListener;
-import org.asynchttpclient.uri.UriComponents;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import javax.net.ssl.SSLContext;
+import static org.asynchttpclient.util.MiscUtils.closeSilently;
 
 import java.io.Closeable;
 import java.io.IOException;
@@ -32,6 +22,16 @@
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Future;
 
+import javax.net.ssl.SSLContext;
+
+import org.asynchttpclient.cookie.Cookie;
+import org.asynchttpclient.multipart.Part;
+import org.asynchttpclient.resumable.ResumableAsyncHandler;
+import org.asynchttpclient.resumable.ResumableIOExceptionFilter;
+import org.asynchttpclient.simple.HeaderMap;
+import org.asynchttpclient.simple.SimpleAHCTransferListener;
+import org.asynchttpclient.uri.UriComponents;
+
 /**
  * Simple implementation of {@link AsyncHttpClient} and it's related builders ({@link AsyncHttpClientConfig},
  * {@link Realm}, {@link ProxyServer} and {@link AsyncHandler}. You can
@@ -64,7 +64,6 @@
  */
 public class SimpleAsyncHttpClient implements Closeable {
 
-    private final static Logger logger = LoggerFactory.getLogger(SimpleAsyncHttpClient.class);
     private final AsyncHttpClientConfig config;
     private final RequestBuilder requestBuilder;
     private AsyncHttpClient asyncHttpClient;
@@ -778,13 +777,8 @@ public Response onCompleted(Response response) throws Exception {
         }
 
         private void closeConsumer() {
-            try {
-                if (bodyConsumer != null) {
-                    bodyConsumer.close();
-                }
-            } catch (IOException ex) {
-                logger.warn("Unable to close a BodyConsumer {}", bodyConsumer);
-            }
+            if (bodyConsumer != null)
+                closeSilently(bodyConsumer);
         }
 
         @Override

api/src/main/java/org/asynchttpclient/extra/ResumableRandomAccessFileListener.java

@@ -12,6 +12,8 @@
  */
 package org.asynchttpclient.extra;
 
+import static org.asynchttpclient.util.MiscUtils.closeSilently;
+
 import org.asynchttpclient.resumable.ResumableListener;
 
 import java.io.IOException;
@@ -52,13 +54,7 @@ public void onBytesReceived(ByteBuffer buffer) throws IOException {
      * {@inheritDoc}
      */
     public void onAllBytesReceived() {
-        if (file != null) {
-            try {
-                file.close();
-            } catch (IOException e) {
-                ;
-            }
-        }
+        closeSilently(file);
     }
 
     /**
@@ -68,9 +64,7 @@ public long length() {
         try {
             return file.length();
         } catch (IOException e) {
-            ;
+            return 0;
         }
-        return 0;
     }
-
 }

api/src/main/java/org/asynchttpclient/resumable/PropertiesBasedResumableProcessor.java

@@ -12,18 +12,19 @@
  */
 package org.asynchttpclient.resumable;
 
-import org.asynchttpclient.util.StandardCharsets;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import static org.asynchttpclient.util.MiscUtils.closeSilently;
 
 import java.io.File;
 import java.io.FileNotFoundException;
 import java.io.FileOutputStream;
-import java.io.IOException;
 import java.util.Map;
 import java.util.Scanner;
 import java.util.concurrent.ConcurrentHashMap;
 
+import org.asynchttpclient.util.StandardCharsets;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
  * A {@link org.asynchttpclient.resumable.ResumableAsyncHandler.ResumableProcessor} which use a properties file
  * to store the download index information.
@@ -81,12 +82,8 @@ public void save(Map<String, Long> map) {
         } catch (Throwable e) {
             log.warn(e.getMessage(), e);
         } finally {
-            if (os != null) {
-                try {
-                    os.close();
-                } catch (IOException ignored) {
-                }
-            }
+            if (os != null)
+                closeSilently(os);
         }
     }
 

api/src/main/java/org/asynchttpclient/util/MiscUtils.java

@@ -12,6 +12,8 @@
  */
 package org.asynchttpclient.util;
 
+import java.io.Closeable;
+import java.io.IOException;
 import java.util.Collection;
 import java.util.Map;
 
@@ -46,6 +48,13 @@ public static boolean getBoolean(String systemPropName, boolean defaultValue) {
     }
 
     public static <T> T withDefault(T value, T defaults) {
-        return value != null? value : value;
+        return value != null ? value : value;
+    }
+
+    public static void closeSilently(Closeable closeable) {
+        try {
+            closeable.close();
+        } catch (IOException e) {
+        }
     }
 }

api/src/test/java/org/asynchttpclient/multipart/MultipartBodyTest.java

@@ -62,8 +62,6 @@ private static File getTestfile() {
     private static void compareContentLength(final List<Part> parts) {
         Assert.assertNotNull(parts);
         // get expected values
-
-        // get real bytes
         final Body multipartBody = MultipartUtils.newMultipartBody(parts, new FluentCaseInsensitiveStringsMap());
         final long expectedContentLength = multipartBody.getContentLength();
         try {

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/body/BodyFileRegion.java

@@ -13,14 +13,16 @@
  */
 package org.asynchttpclient.providers.netty.request.body;
 
+import static org.asynchttpclient.util.MiscUtils.closeSilently;
+
+
 import org.asynchttpclient.RandomAccessBody;
 
 import io.netty.channel.FileRegion;
 import io.netty.util.AbstractReferenceCounted;
 
 import java.io.IOException;
 import java.nio.channels.WritableByteChannel;
-
 /**
  * Adapts a {@link RandomAccessBody} to Netty's {@link FileRegion}.
  */
@@ -61,10 +63,6 @@ public long transferTo(WritableByteChannel target, long position) throws IOExcep
 
     @Override
     protected void deallocate() {
-        try {
-            body.close();
-        } catch (IOException e) {
-            // we tried
-        }
+        closeSilently(body);
     }
 }

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/body/NettyBodyBody.java

@@ -13,6 +13,15 @@
  */
 package org.asynchttpclient.providers.netty.request.body;
 
+import static org.asynchttpclient.util.MiscUtils.closeSilently;
+import io.netty.channel.Channel;
+import io.netty.channel.ChannelFuture;
+import io.netty.channel.ChannelProgressiveFuture;
+import io.netty.handler.codec.http.LastHttpContent;
+import io.netty.handler.stream.ChunkedWriteHandler;
+
+import java.io.IOException;
+
 import org.asynchttpclient.AsyncHttpClientConfig;
 import org.asynchttpclient.Body;
 import org.asynchttpclient.BodyGenerator;
@@ -22,21 +31,9 @@
 import org.asynchttpclient.providers.netty.future.NettyResponseFuture;
 import org.asynchttpclient.providers.netty.request.ProgressListener;
 import org.asynchttpclient.providers.netty.request.body.FeedableBodyGenerator.FeedListener;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import io.netty.channel.Channel;
-import io.netty.channel.ChannelFuture;
-import io.netty.channel.ChannelProgressiveFuture;
-import io.netty.handler.codec.http.LastHttpContent;
-import io.netty.handler.stream.ChunkedWriteHandler;
-
-import java.io.IOException;
 
 public class NettyBodyBody implements NettyBody {
 
-    private static final Logger LOGGER = LoggerFactory.getLogger(NettyBodyBody.class);
-
     private final Body body;
     private final NettyAsyncHttpProviderConfig nettyConfig;
 
@@ -63,7 +60,7 @@ public String getContentType() {
     public void write(final Channel channel, NettyResponseFuture<?> future, AsyncHttpClientConfig config) throws IOException {
 
         Object msg;
-        if (!ChannelManager.isSslHandlerConfigured(channel.pipeline()) && body instanceof RandomAccessBody && !nettyConfig.isDisableZeroCopy()) {
+        if (body instanceof RandomAccessBody && !ChannelManager.isSslHandlerConfigured(channel.pipeline()) && !nettyConfig.isDisableZeroCopy()) {
             msg = new BodyFileRegion((RandomAccessBody) body);
 
         } else {
@@ -83,11 +80,7 @@ public void onContentAdded() {
 
         writeFuture.addListener(new ProgressListener(config, future.getAsyncHandler(), future, false, getContentLength()) {
             public void operationComplete(ChannelProgressiveFuture cf) {
-                try {
-                    body.close();
-                } catch (IOException e) {
-                    LOGGER.warn("Failed to close request body: {}", e.getMessage(), e);
-                }
+                closeSilently(body);
                 super.operationComplete(cf);
             }
         });

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/body/NettyFileBody.java

@@ -13,6 +13,7 @@
  */
 package org.asynchttpclient.providers.netty.request.body;
 
+import static org.asynchttpclient.util.MiscUtils.closeSilently;
 import io.netty.channel.Channel;
 import io.netty.channel.ChannelFuture;
 import io.netty.channel.ChannelProgressiveFuture;
@@ -30,13 +31,9 @@
 import org.asynchttpclient.providers.netty.channel.ChannelManager;
 import org.asynchttpclient.providers.netty.future.NettyResponseFuture;
 import org.asynchttpclient.providers.netty.request.ProgressListener;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 public class NettyFileBody implements NettyBody {
 
-    private static final Logger LOGGER = LoggerFactory.getLogger(NettyFileBody.class);
-
     private final File file;
     private final long offset;
     private final long length;
@@ -88,23 +85,13 @@ public void write(Channel channel, NettyResponseFuture<?> future, AsyncHttpClien
             }
             writeFuture.addListener(new ProgressListener(config, future.getAsyncHandler(), future, false, getContentLength()) {
                 public void operationComplete(ChannelProgressiveFuture cf) {
-                    try {
-                        // FIXME probably useless in Netty 4
-                        raf.close();
-                    } catch (IOException e) {
-                        LOGGER.warn("Failed to close request body: {}", e.getMessage(), e);
-                    }
+                    closeSilently(raf);
                     super.operationComplete(cf);
                 }
             });
             channel.writeAndFlush(LastHttpContent.EMPTY_LAST_CONTENT);
         } catch (IOException ex) {
-            if (raf != null) {
-                try {
-                    raf.close();
-                } catch (IOException e) {
-                }
-            }
+            closeSilently(raf);
             throw ex;
         }
     }

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/body/NettyInputStreamBody.java

@@ -13,6 +13,8 @@
  */
 package org.asynchttpclient.providers.netty.request.body;
 
+import static org.asynchttpclient.util.MiscUtils.closeSilently;
+
 import org.asynchttpclient.AsyncHttpClientConfig;
 import org.asynchttpclient.providers.netty.future.NettyResponseFuture;
 import org.asynchttpclient.providers.netty.request.ProgressListener;
@@ -69,11 +71,7 @@ public void write(Channel channel, NettyResponseFuture<?> future, AsyncHttpClien
         channel.write(new ChunkedStream(is), channel.newProgressivePromise()).addListener(
                 new ProgressListener(config, future.getAsyncHandler(), future, false, getContentLength()) {
                     public void operationComplete(ChannelProgressiveFuture cf) {
-                        try {
-                            is.close();
-                        } catch (IOException e) {
-                            LOGGER.warn("Failed to close request body: {}", e.getMessage(), e);
-                        }
+                        closeSilently(is);
                         super.operationComplete(cf);
                     }
                 });