Skip to content

Commit 501455c

Browse files
committed
Explicitly add Cloneable interface to GlideOptions and GlideRequests.
It seems like this shouldn’t be necessary, but it fixes a PMD warning. Fixes bumptech#2394.
1 parent b2fb229 commit 501455c

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/RequestBuilderGenerator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ TypeSpec generate(String generatedCodePackageName, @Nullable TypeSpec generatedO
165165
.addModifiers(Modifier.PUBLIC)
166166
.addTypeVariable(transcodeTypeName)
167167
.superclass(requestBuilderOfTranscodeType)
168+
.addSuperinterface(Cloneable.class)
168169
.addMethods(generateConstructors())
169170
.addMethod(generateDownloadOnlyRequestMethod())
170171
.addMethods(generateGeneratedRequestOptionsEquivalents(generatedOptions))

annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/RequestOptionsGenerator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ public MethodSignature apply(MethodAndStaticVar f) {
138138
.addJavadoc(generateClassJavadoc(glideExtensionClassNames))
139139
.addModifiers(Modifier.FINAL)
140140
.addModifiers(Modifier.PUBLIC)
141+
.addSuperinterface(Cloneable.class)
141142
.superclass(requestOptionsName);
142143

143144
for (MethodAndStaticVar methodAndStaticVar : allMethodsAndStaticVars) {

0 commit comments

Comments
 (0)