Add additional handler extension callbacks

Resolves AsyncHttpClient#732.

Author: barnardb

api/src/main/java/org/asynchttpclient/AsyncHandlerExtensions.java

@@ -59,4 +59,14 @@ public interface AsyncHandlerExtensions {
      * Notify the callback every time a request is being retried.
      */
     void onRetry();
+
+    /**
+     * Notify the callback after DNS resolution has completed.
+     */
+    void onDnsResolved();
+
+    /**
+     * Notify the callback when the SSL handshake performed to establish an HTTPS connection has been completed.
+     */
+    void onSslHandshakeCompleted();
 }

api/src/test/java/org/asynchttpclient/async/util/EventCollectingHandler.java

@@ -85,4 +85,14 @@ public void onSendRequest(Object request) {
     public void onRetry() {
         firedEvents.add("Retry");
     }
+
+    @Override
+    public void onDnsResolved() {
+        firedEvents.add("DnsResolved");
+    }
+
+    @Override
+    public void onSslHandshakeCompleted() {
+        firedEvents.add("SslHandshakeCompleted");
+    }
 }

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/NettyConnectListener.java

@@ -29,6 +29,7 @@
 import javax.net.ssl.SSLEngine;
 import javax.net.ssl.SSLSession;
 
+import org.asynchttpclient.AsyncHandler;
 import org.asynchttpclient.AsyncHandlerExtensions;
 import org.asynchttpclient.AsyncHttpClientConfig;
 import org.asynchttpclient.providers.netty.channel.ChannelManager;
@@ -106,6 +107,10 @@ public void operationComplete(Future<? super Channel> handshakeFuture) throws Ex
                         LOGGER.debug("onFutureSuccess: session = {}, id = {}, isValid = {}, host = {}", session.toString(),
                                 Base64.encode(session.getId()), session.isValid(), host);
                         if (hostnameVerifier.verify(host, session)) {
+                            final AsyncHandler<T> asyncHandler = future.getAsyncHandler();
+                            if (asyncHandler instanceof AsyncHandlerExtensions)
+                                AsyncHandlerExtensions.class.cast(asyncHandler).onSslHandshakeCompleted();
+
                             writeRequest(channel);
                         } else {
                             abortChannelPreemption(poolKey);

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/NettyRequestSender.java

@@ -271,7 +271,7 @@ private <T> ListenableFuture<T> sendRequestWithNewChannel(//
             if (asyncHandler instanceof AsyncHandlerExtensions)
                 AsyncHandlerExtensions.class.cast(asyncHandler).onOpenConnection();
 
-            ChannelFuture channelFuture = connect(request, uri, proxy, useProxy, bootstrap);
+            ChannelFuture channelFuture = connect(request, uri, proxy, useProxy, bootstrap, asyncHandler);
             channelFuture.addListener(new NettyConnectListener<T>(config, future, this, channelManager, channelPreempted, poolKey));
 
         } catch (Throwable t) {
@@ -354,9 +354,12 @@ else if (!useProxy || avoidProxy(proxy, uri.getHost()))
             return new InetSocketAddress(proxy.getHost(), proxy.getPort());
     }
 
-    private ChannelFuture connect(Request request, Uri uri, ProxyServer proxy, boolean useProxy, Bootstrap bootstrap) {
+    private ChannelFuture connect(Request request, Uri uri, ProxyServer proxy, boolean useProxy, Bootstrap bootstrap, AsyncHandler<?> asyncHandler) {
         InetSocketAddress remoteAddress = remoteAddress(request, uri, proxy, useProxy);
 
+        if (asyncHandler instanceof AsyncHandlerExtensions)
+            AsyncHandlerExtensions.class.cast(asyncHandler).onDnsResolved();
+
         if (request.getLocalAddress() != null)
             return bootstrap.connect(remoteAddress, new InetSocketAddress(request.getLocalAddress(), 0));
         else

providers/netty/src/test/java/org/asynchttpclient/providers/netty/NettyAsyncProviderBasicTest.java

@@ -58,6 +58,7 @@ public void testNewConnectionEventsFired() throws Exception {
             List<String> expectedEvents = Arrays.asList(
                     "PoolConnection",
                     "OpenConnection",
+                    "DnsResolved",
                     "ConnectionOpen",
                     "SendRequest",
                     "HeaderWriteCompleted",

providers/netty/src/test/java/org/asynchttpclient/providers/netty/NettyBasicHttpsTest.java

@@ -40,6 +40,8 @@ public void testNormalEventsFired() throws InterruptedException, TimeoutExceptio
             List<String> expectedEvents = Arrays.asList(
                     "PoolConnection",
                     "OpenConnection",
+                    "DnsResolved",
+                    "SslHandshakeCompleted",
                     "ConnectionOpen",
                     "SendRequest",
                     "HeaderWriteCompleted",