Merge pull request #28 from velog-io/fix/notification-by-self

fix: cannot create notification for self

Author: winverse

packages/velog-server/src/services/NotificationService/index.ts

@@ -1,4 +1,5 @@
 import { BadRequestError } from '@errors/BadRequestErrors.js'
+import { ConfilctError } from '@errors/ConfilctError'
 import { ForbiddenError } from '@errors/ForbiddenError.js'
 import { NotFoundError } from '@errors/NotfoundError.js'
 import { UnauthorizedError } from '@errors/UnauthorizedError.js'
@@ -128,6 +129,10 @@ export class NotificationService implements Service {
       throw new BadRequestError('Not found action')
     }
 
+    if (fkUserId === actor.id) {
+      throw new ConfilctError('Cannot target the same user as actor')
+    }
+
     const action = (actionInfo as any)[type]
 
     const validate = this.notificationActionValidate(type, action)

packages/velog-server/src/services/PostLikeService/index.ts

@@ -92,26 +92,28 @@ export class PostLikeService implements Service {
       },
     })
 
-    // create notification
-    await this.notificationService.createOrUpdate({
-      fkUserId: post.fk_user_id,
-      actorId: signedUserId,
-      actionId: post.id,
-      type: 'postLike',
-      action: {
-        postLike: {
-          post_like_id: postLike.id,
-          actor_display_name: signedUser.profile?.display_name || '',
-          actor_thumbnail: signedUser.profile?.thumbnail || '',
-          actor_username: signedUser.username,
-          post_id: likesPost.id,
-          post_title: likesPost.title || '',
-          post_url_slug: likesPost.url_slug || '',
-          post_writer_username: likesPost.user.username,
-          type: 'postLike',
+    if (post.fk_user_id !== signedUserId) {
+      // create notification
+      await this.notificationService.createOrUpdate({
+        fkUserId: post.fk_user_id,
+        actorId: signedUserId,
+        actionId: post.id,
+        type: 'postLike',
+        action: {
+          postLike: {
+            post_like_id: postLike.id,
+            actor_display_name: signedUser.profile?.display_name || '',
+            actor_thumbnail: signedUser.profile?.thumbnail || '',
+            actor_username: signedUser.username,
+            post_id: likesPost.id,
+            post_title: likesPost.title || '',
+            post_url_slug: likesPost.url_slug || '',
+            post_writer_username: likesPost.user.username,
+            type: 'postLike',
+          },
         },
-      },
-    })
+      })
+    }
 
     const unscored = this.utils.checkUnscore(post.body!.concat(post.title || ''))
     if (!unscored) {