Skip to content

Commit b701313

Browse files
committed
Split Setup Issues into Groups
Summary: Groups setup issues into Important, PHP, MySQL, and Base for easier parsing on initial installations. Test Plan: Test my internal server and various issues. {F289699} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7207 Differential Revision: https://secure.phabricator.com/D11726
1 parent 91a1f56 commit b701313

25 files changed

+167
-20
lines changed

src/applications/config/check/PhabricatorAPCSetupCheck.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
final class PhabricatorAPCSetupCheck extends PhabricatorSetupCheck {
44

5+
public function getDefaultGroup() {
6+
return self::GROUP_OTHER;
7+
}
8+
59
protected function executeChecks() {
610
if (!extension_loaded('apc')) {
711
$message = pht(

src/applications/config/check/PhabricatorAuthSetupCheck.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
final class PhabricatorAuthSetupCheck extends PhabricatorSetupCheck {
44

5+
public function getDefaultGroup() {
6+
return self::GROUP_IMPORTANT;
7+
}
8+
59
protected function executeChecks() {
610
// NOTE: We're not actually building these providers. Building providers
711
// can require additional configuration to be present (e.g., to build

src/applications/config/check/PhabricatorBaseURISetupCheck.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
final class PhabricatorBaseURISetupCheck extends PhabricatorSetupCheck {
44

5+
public function getDefaultGroup() {
6+
return self::GROUP_IMPORTANT;
7+
}
8+
59
protected function executeChecks() {
610
$base_uri = PhabricatorEnv::getEnvConfig('phabricator.base-uri');
711

src/applications/config/check/PhabricatorBinariesSetupCheck.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
final class PhabricatorBinariesSetupCheck extends PhabricatorSetupCheck {
44

5+
public function getDefaultGroup() {
6+
return self::GROUP_OTHER;
7+
}
58

69
protected function executeChecks() {
710

src/applications/config/check/PhabricatorDaemonsSetupCheck.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
final class PhabricatorDaemonsSetupCheck extends PhabricatorSetupCheck {
44

5+
public function getDefaultGroup() {
6+
return self::GROUP_IMPORTANT;
7+
}
8+
59
protected function executeChecks() {
610

711
$task_daemon = id(new PhabricatorDaemonLogQuery())

src/applications/config/check/PhabricatorDatabaseSetupCheck.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
final class PhabricatorDatabaseSetupCheck extends PhabricatorSetupCheck {
44

5+
public function getDefaultGroup() {
6+
return self::GROUP_IMPORTANT;
7+
}
8+
59
public function getExecutionOrder() {
610
// This must run after basic PHP checks, but before most other checks.
711
return 0.5;

src/applications/config/check/PhabricatorElasticSetupCheck.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
final class PhabricatorElasticSetupCheck extends PhabricatorSetupCheck {
44

5+
public function getDefaultGroup() {
6+
return self::GROUP_OTHER;
7+
}
8+
59
protected function executeChecks() {
610
if (PhabricatorDefaultSearchEngineSelector::shouldUseElasticSearch()) {
711
$engine = PhabricatorSearchEngineSelector::newSelector()->newEngine();

src/applications/config/check/PhabricatorExtensionsSetupCheck.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
final class PhabricatorExtensionsSetupCheck extends PhabricatorSetupCheck {
44

5+
public function getDefaultGroup() {
6+
return self::GROUP_PHP;
7+
}
8+
59
public function getExecutionOrder() {
610
return 0;
711
}

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
final class PhabricatorExtraConfigSetupCheck extends PhabricatorSetupCheck {
44

5+
public function getDefaultGroup() {
6+
return self::GROUP_OTHER;
7+
}
8+
59
protected function executeChecks() {
610
$ancient_config = self::getAncientConfig();
711

src/applications/config/check/PhabricatorFileinfoSetupCheck.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
final class PhabricatorFileinfoSetupCheck extends PhabricatorSetupCheck {
44

5+
public function getDefaultGroup() {
6+
return self::GROUP_OTHER;
7+
}
8+
59
protected function executeChecks() {
610
if (!extension_loaded('fileinfo')) {
711
$message = pht(

0 commit comments

Comments
 (0)