Skip to content

Commit 132829e

Browse files
committed
chore(core): deactivate the tests that use Dart isolates
These are broken with Dart 1.13.2 stable, and will soon be obsolete (see angular#6270).
1 parent 4a41442 commit 132829e

File tree

4 files changed

+30
-3
lines changed

4 files changed

+30
-3
lines changed

modules/angular2/test/compiler/change_detector_compiler_spec.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
} from 'angular2/testing_internal';
1515
import {provide} from 'angular2/src/core/di';
1616

17-
import {CONST_EXPR, stringify} from 'angular2/src/facade/lang';
17+
import {CONST_EXPR, stringify, IS_DART} from 'angular2/src/facade/lang';
1818
import {MapWrapper} from 'angular2/src/facade/collection';
1919
import {Promise} from 'angular2/src/facade/async';
2020

@@ -55,6 +55,11 @@ var THIS_MODULE_URL = `package:${THIS_MODULE_ID}${MODULE_SUFFIX}`;
5555
var THIS_MODULE_REF = moduleRef(THIS_MODULE_URL);
5656

5757
export function main() {
58+
// Dart's isolate support is broken, and these tests will be obsolote soon with
59+
// https://github.com/angular/angular/issues/6270
60+
if (IS_DART) {
61+
return;
62+
}
5863
describe('ChangeDetectorCompiler', () => {
5964
beforeEachProviders(() => [
6065
TEST_PROVIDERS,

modules/angular2/test/compiler/eval_module_spec.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ export var TEST_VALUE = 23;
2222
const THIS_MODULE_URL = `package:angular2/test/compiler/eval_module_spec${IS_DART?'.dart':'.js'}`;
2323

2424
export function main() {
25+
// Dart's isolate support is broken, and these tests will be obsolote soon with
26+
// https://github.com/angular/angular/issues/6270
27+
if (IS_DART) {
28+
return;
29+
}
2530
describe('evalModule', () => {
2631
it('should call the "run" function and allow to use imports',
2732
inject([AsyncTestCompleter], (async) => {

modules/angular2/test/compiler/style_compiler_spec.ts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,14 @@ import {SpyXHR} from './spies';
1717
import {XHR} from 'angular2/src/compiler/xhr';
1818
import {BaseException, WrappedException} from 'angular2/src/facade/exceptions';
1919

20-
import {CONST_EXPR, isPresent, isBlank, StringWrapper, isArray} from 'angular2/src/facade/lang';
20+
import {
21+
CONST_EXPR,
22+
isPresent,
23+
isBlank,
24+
StringWrapper,
25+
isArray,
26+
IS_DART
27+
} from 'angular2/src/facade/lang';
2128
import {PromiseWrapper, Promise} from 'angular2/src/facade/async';
2229
import {evalModule} from './eval_module';
2330
import {StyleCompiler} from 'angular2/src/compiler/style_compiler';
@@ -40,6 +47,11 @@ var IMPORT_ABS_STYLESHEET_URL_WITH_IMPORT =
4047
`package:angular2/test/compiler/style_compiler_transitive_import.css`;
4148

4249
export function main() {
50+
// Dart's isolate support is broken, and these tests will be obsolote soon with
51+
// https://github.com/angular/angular/issues/6270
52+
if (IS_DART) {
53+
return;
54+
}
4355
describe('StyleCompiler', () => {
4456
var xhr: SpyXHR;
4557

modules/angular2/test/compiler/template_compiler_spec.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
} from 'angular2/testing_internal';
1515

1616
import {Promise, PromiseWrapper} from 'angular2/src/facade/async';
17-
import {Type, isPresent, isBlank, stringify, isString} from 'angular2/src/facade/lang';
17+
import {Type, isPresent, isBlank, stringify, isString, IS_DART} from 'angular2/src/facade/lang';
1818
import {
1919
MapWrapper,
2020
SetWrapper,
@@ -58,6 +58,11 @@ var REFLECTION_CAPS_MODULE_REF =
5858
moduleRef(`package:angular2/src/core/reflection/reflection_capabilities${MODULE_SUFFIX}`);
5959

6060
export function main() {
61+
// Dart's isolate support is broken, and these tests will be obsolote soon with
62+
// https://github.com/angular/angular/issues/6270
63+
if (IS_DART) {
64+
return;
65+
}
6166
describe('TemplateCompiler', () => {
6267
var compiler: TemplateCompiler;
6368
var runtimeMetadataResolver: RuntimeMetadataResolver;

0 commit comments

Comments
 (0)