Skip to content

Commit 19105dc

Browse files
committed
DATAES-55 - polish test cases and remove unwanted files
Test cases were scanning entire package for repositories, created dedicated package for individual repository.
1 parent 30ebcc0 commit 19105dc

20 files changed

+59
-23
lines changed

src/test/java/org/springframework/data/elasticsearch/InnerObjectTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import org.junit.runner.RunWith;
2626
import org.springframework.beans.factory.annotation.Autowired;
2727
import org.springframework.data.elasticsearch.core.ElasticsearchTemplate;
28-
import org.springframework.data.elasticsearch.repositories.SampleElasticSearchBookRepository;
28+
import org.springframework.data.elasticsearch.repositories.book.SampleElasticSearchBookRepository;
2929
import org.springframework.test.context.ContextConfiguration;
3030
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
3131

src/test/java/org/springframework/data/elasticsearch/NonDocumentEntityTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import org.junit.Test;
1919
import org.springframework.beans.factory.BeanCreationException;
2020
import org.springframework.context.support.ClassPathXmlApplicationContext;
21-
import org.springframework.data.elasticsearch.repositories.NonDocumentEntityRepository;
21+
import org.springframework.data.elasticsearch.repositories.nondocument.NonDocumentEntityRepository;
2222

2323
/**
2424
* @author Rizwan Idrees

src/test/java/org/springframework/data/elasticsearch/config/ElasticsearchNamespaceHandlerTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import org.springframework.context.ApplicationContext;
2626
import org.springframework.data.elasticsearch.client.NodeClientFactoryBean;
2727
import org.springframework.data.elasticsearch.client.TransportClientFactoryBean;
28-
import org.springframework.data.elasticsearch.repositories.SampleElasticsearchRepository;
28+
import org.springframework.data.elasticsearch.repositories.sample.SampleElasticsearchRepository;
2929
import org.springframework.test.context.ContextConfiguration;
3030
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
3131

src/test/java/org/springframework/data/elasticsearch/config/EnableElasticsearchRepositoriesTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import org.springframework.context.annotation.Configuration;
2727
import org.springframework.data.elasticsearch.core.ElasticsearchOperations;
2828
import org.springframework.data.elasticsearch.core.ElasticsearchTemplate;
29-
import org.springframework.data.elasticsearch.repositories.SampleElasticsearchRepository;
29+
import org.springframework.data.elasticsearch.repositories.sample.SampleElasticsearchRepository;
3030
import org.springframework.data.elasticsearch.repository.config.EnableElasticsearchRepositories;
3131
import org.springframework.test.context.ContextConfiguration;
3232
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
@@ -40,7 +40,7 @@
4040
public class EnableElasticsearchRepositoriesTests {
4141

4242
@Configuration
43-
@EnableElasticsearchRepositories(basePackages = "org.springframework.data.elasticsearch.repositories")
43+
@EnableElasticsearchRepositories(basePackages = "org.springframework.data.elasticsearch.repositories.sample")
4444
static class Config {
4545

4646
@Bean

src/test/java/org/springframework/data/elasticsearch/repositories/CustomMethodRepositoryTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import org.springframework.data.domain.Sort;
3232
import org.springframework.data.elasticsearch.SampleEntity;
3333
import org.springframework.data.elasticsearch.core.ElasticsearchTemplate;
34+
import org.springframework.data.elasticsearch.repositories.custom.SampleCustomMethodRepository;
3435
import org.springframework.test.context.ContextConfiguration;
3536
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
3637

src/test/java/org/springframework/data/elasticsearch/repositories/SampleElasticSearchBookRepository.java renamed to src/test/java/org/springframework/data/elasticsearch/repositories/book/SampleElasticSearchBookRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.elasticsearch.repositories;
16+
package org.springframework.data.elasticsearch.repositories.book;
1717

1818
import org.springframework.data.elasticsearch.Book;
1919
import org.springframework.data.elasticsearch.repository.ElasticsearchRepository;

src/test/java/org/springframework/data/elasticsearch/repositories/SampleCustomMethodRepository.java renamed to src/test/java/org/springframework/data/elasticsearch/repositories/custom/SampleCustomMethodRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.elasticsearch.repositories;
16+
package org.springframework.data.elasticsearch.repositories.custom;
1717

1818
import java.util.List;
1919

src/test/java/org/springframework/data/elasticsearch/repositories/DoubleIDRepository.java renamed to src/test/java/org/springframework/data/elasticsearch/repositories/doubleid/DoubleIDRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.elasticsearch.repositories;
16+
package org.springframework.data.elasticsearch.repositories.doubleid;
1717

1818
import org.springframework.data.elasticsearch.DoubleIDEntity;
1919
import org.springframework.data.elasticsearch.repository.ElasticsearchRepository;

src/test/java/org/springframework/data/elasticsearch/repositories/IntegerIDRepository.java renamed to src/test/java/org/springframework/data/elasticsearch/repositories/integer/IntegerIDRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.elasticsearch.repositories;
16+
package org.springframework.data.elasticsearch.repositories.integer;
1717

1818
import org.springframework.data.elasticsearch.IntegerIDEntity;
1919
import org.springframework.data.elasticsearch.repository.ElasticsearchRepository;

src/test/java/org/springframework/data/elasticsearch/repositories/NonDocumentEntityRepository.java renamed to src/test/java/org/springframework/data/elasticsearch/repositories/nondocument/NonDocumentEntityRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.elasticsearch.repositories;
16+
package org.springframework.data.elasticsearch.repositories.nondocument;
1717

1818
import org.springframework.context.annotation.Lazy;
1919
import org.springframework.data.elasticsearch.NonDocumentEntity;

src/test/java/org/springframework/data/elasticsearch/repositories/SampleElasticsearchRepository.java renamed to src/test/java/org/springframework/data/elasticsearch/repositories/sample/SampleElasticsearchRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.elasticsearch.repositories;
16+
package org.springframework.data.elasticsearch.repositories.sample;
1717

1818
import org.springframework.data.elasticsearch.SampleEntity;
1919
import org.springframework.data.elasticsearch.repository.ElasticsearchRepository;

src/test/java/org/springframework/data/elasticsearch/repository/support/DoubleIDRepositoryTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import org.springframework.beans.factory.annotation.Autowired;
2828
import org.springframework.data.elasticsearch.DoubleIDEntity;
2929
import org.springframework.data.elasticsearch.core.ElasticsearchTemplate;
30-
import org.springframework.data.elasticsearch.repositories.DoubleIDRepository;
30+
import org.springframework.data.elasticsearch.repositories.doubleid.DoubleIDRepository;
3131
import org.springframework.test.context.ContextConfiguration;
3232
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
3333

@@ -37,7 +37,7 @@
3737
*/
3838

3939
@RunWith(SpringJUnit4ClassRunner.class)
40-
@ContextConfiguration("classpath:/simple-repository-test.xml")
40+
@ContextConfiguration("classpath:/double-id-repository-test.xml")
4141
public class DoubleIDRepositoryTests {
4242

4343
@Autowired

src/test/java/org/springframework/data/elasticsearch/repository/support/IntegerIDRepositoryTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import org.springframework.beans.factory.annotation.Autowired;
2828
import org.springframework.data.elasticsearch.IntegerIDEntity;
2929
import org.springframework.data.elasticsearch.core.ElasticsearchTemplate;
30-
import org.springframework.data.elasticsearch.repositories.IntegerIDRepository;
30+
import org.springframework.data.elasticsearch.repositories.integer.IntegerIDRepository;
3131
import org.springframework.test.context.ContextConfiguration;
3232
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
3333

@@ -37,7 +37,7 @@
3737
*/
3838

3939
@RunWith(SpringJUnit4ClassRunner.class)
40-
@ContextConfiguration("classpath:/simple-repository-test.xml")
40+
@ContextConfiguration("classpath:/integer-id-repository-test.xml")
4141
public class IntegerIDRepositoryTests {
4242

4343
@Autowired

src/test/java/org/springframework/data/elasticsearch/repository/support/SimpleElasticsearchRepositoryTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
import org.springframework.data.elasticsearch.core.ElasticsearchTemplate;
3737
import org.springframework.data.elasticsearch.core.query.NativeSearchQueryBuilder;
3838
import org.springframework.data.elasticsearch.core.query.SearchQuery;
39-
import org.springframework.data.elasticsearch.repositories.SampleElasticsearchRepository;
39+
import org.springframework.data.elasticsearch.repositories.sample.SampleElasticsearchRepository;
4040
import org.springframework.test.context.ContextConfiguration;
4141
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
4242

src/test/resources/custom-method-repository-test.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515

1616
<elasticsearch:repositories
17-
base-package="org.springframework.data.elasticsearch.repositories"/>
18-
17+
base-package="org.springframework.data.elasticsearch.repositories.custom"/>
1918

2019
</beans>
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<beans xmlns="http://www.springframework.org/schema/beans"
3+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
4+
xmlns:elasticsearch="http://www.springframework.org/schema/data/elasticsearch"
5+
xsi:schemaLocation="http://www.springframework.org/schema/data/elasticsearch http://www.springframework.org/schema/data/elasticsearch/spring-elasticsearch-1.0.xsd
6+
http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.1.xsd">
7+
8+
<import resource="infrastructure.xml"/>
9+
10+
<bean name="elasticsearchTemplate"
11+
class="org.springframework.data.elasticsearch.core.ElasticsearchTemplate">
12+
<constructor-arg name="client" ref="client"/>
13+
</bean>
14+
15+
16+
<elasticsearch:repositories
17+
base-package="org.springframework.data.elasticsearch.repositories.doubleid"/>
18+
19+
</beans>
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<beans xmlns="http://www.springframework.org/schema/beans"
3+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
4+
xmlns:elasticsearch="http://www.springframework.org/schema/data/elasticsearch"
5+
xsi:schemaLocation="http://www.springframework.org/schema/data/elasticsearch http://www.springframework.org/schema/data/elasticsearch/spring-elasticsearch-1.0.xsd
6+
http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.1.xsd">
7+
8+
<import resource="infrastructure.xml"/>
9+
10+
<bean name="elasticsearchTemplate"
11+
class="org.springframework.data.elasticsearch.core.ElasticsearchTemplate">
12+
<constructor-arg name="client" ref="client"/>
13+
</bean>
14+
15+
16+
<elasticsearch:repositories
17+
base-package="org.springframework.data.elasticsearch.repositories.integer"/>
18+
19+
</beans>

src/test/resources/org/springframework/data/elasticsearch/config/namespace.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
<elasticsearch:transport-client id="transportClient"/>
1717

1818
<elasticsearch:repositories
19-
base-package="org.springframework.data.elasticsearch.repositories"/>
20-
19+
base-package="org.springframework.data.elasticsearch.repositories.sample"/>
2120

2221
</beans>

src/test/resources/repository-non-document-entity.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
<constructor-arg name="client" ref="client"/>
1313
</bean>
1414

15-
<elasticsearch:repositories base-package="org.springframework.data.elasticsearch"/>
15+
<elasticsearch:repositories base-package="org.springframework.data.elasticsearch.repositories.nondocument"/>
1616

1717
</beans>

src/test/resources/simple-repository-test.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515

1616
<elasticsearch:repositories
17-
base-package="org.springframework.data.elasticsearch.repositories"/>
18-
17+
base-package="org.springframework.data.elasticsearch.repositories.sample"/>
1918

2019
</beans>

0 commit comments

Comments
 (0)