Skip to content

Commit 8e40c49

Browse files
authored
Merge pull request trungvose#47 from trungk18/phase1-bugs-fixing
Phase1 bugs fixing
2 parents 7629f96 + 26af244 commit 8e40c49

File tree

5 files changed

+10
-9
lines changed

5 files changed

+10
-9
lines changed

backend/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frontend/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frontend/src/app/project/project.guard.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ export class ProjectGuard implements CanActivate {
1919
}
2020

2121
getFromStoreOrApi(): Observable<ProjectState> {
22-
return combineLatest([this._projectQuery.all$, this._projectQuery.isLoading$]).pipe(
23-
map(([state, loading]) => {
22+
return combineLatest([this._projectQuery.all$, this._projectQuery.isLoading$]).pipe(
23+
map(([state, loading]) => {
2424
if (!loading) {
25-
this._projectService.getProject().subscribe();
25+
this._projectService.getProject();
2626
}
2727
return state;
2828
}),

frontend/src/app/project/state/project/project.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ export class ProjectService {
2424
this._store.setLoading(isLoading);
2525
}
2626

27-
getProject(): Subscription {
27+
getProject() {
2828
this.setLoading(true);
29-
return this._http
29+
this._http
3030
.get<JProject>(`${this.baseUrl}/project`)
3131
.pipe(
3232
map((project) => {

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
"start:back": "npm run install-dependencies-back && cd backend && npm run start:dev",
1212
"build:back": "cd backend && npm run build",
1313
"build": "npm run install-dependencies && npm run build:back && npm run build:front",
14-
"heroku-postbuild": "npm run install-dependencies-back && npm run build:back"
14+
"heroku-postbuild": "npm run install-dependencies-back && npm run build:back",
15+
"netlify-build": "npm run install-dependencies-front && npm run build:front"
1516
},
1617
"repository": {
1718
"type": "git",

0 commit comments

Comments
 (0)