Skip to content

Commit 756129f

Browse files
committed
modify validAccountId
1 parent 9c7b29b commit 756129f

File tree

1 file changed

+9
-13
lines changed

1 file changed

+9
-13
lines changed

actuator/src/main/java/org/tron/core/utils/TransactionUtil.java

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import com.google.protobuf.ByteString;
2424
import java.security.SignatureException;
2525
import java.util.ArrayList;
26-
import java.util.Arrays;
2726
import java.util.List;
2827
import lombok.extern.slf4j.Slf4j;
2928
import org.apache.commons.lang3.ArrayUtils;
@@ -35,7 +34,6 @@
3534
import org.tron.api.GrpcAPI.TransactionSignWeight;
3635
import org.tron.api.GrpcAPI.TransactionSignWeight.Result;
3736
import org.tron.common.parameter.CommonParameter;
38-
import org.tron.common.crypto.Hash;
3937
import org.tron.common.utils.Sha256Hash;
4038
import org.tron.core.ChainBaseManager;
4139
import org.tron.core.capsule.AccountCapsule;
@@ -49,9 +47,6 @@
4947
import org.tron.protos.Protocol.Transaction.Result.contractResult;
5048
import org.tron.protos.Protocol.TransactionSign;
5149
import org.tron.protos.contract.SmartContractOuterClass.CreateSmartContract;
52-
import org.tron.protos.contract.SmartContractOuterClass.SmartContract;
53-
import org.tron.protos.contract.SmartContractOuterClass.SmartContract.ABI;
54-
import org.tron.protos.contract.SmartContractOuterClass.SmartContract.ABI.Entry.StateMutabilityType;
5550
import org.tron.protos.contract.SmartContractOuterClass.TriggerSmartContract;
5651

5752
@Slf4j(topic = "capsule")
@@ -67,8 +62,16 @@ public class TransactionUtil {
6762
@Autowired
6863
private ChainBaseManager chainBaseManager;
6964

65+
public static boolean validAccountName(byte[] accountName) {
66+
if (ArrayUtils.isEmpty(accountName)) {
67+
return true; //account name can be empty
68+
}
69+
70+
return accountName.length <= maxAccountNameLen;
71+
}
72+
7073
public static boolean validAccountId(byte[] accountId) {
71-
return validReadableBytes(accountId, maxAccountIdLen) && accountId.length < minAccountIdLen;
74+
return validReadableBytes(accountId, maxAccountIdLen) && accountId.length >= minAccountIdLen;
7275
}
7376

7477
public static boolean validAssetName(byte[] assetName) {
@@ -95,13 +98,6 @@ private static boolean validReadableBytes(byte[] bytes, int maxLength) {
9598
return true;
9699
}
97100

98-
public static boolean validAccountName(byte[] accountName) {
99-
if (ArrayUtils.isEmpty(accountName)) {
100-
return true; //account name can be empty
101-
}
102-
return accountName.length <= maxAccountNameLen;
103-
}
104-
105101
public static boolean validAssetDescription(byte[] description) {
106102
if (ArrayUtils.isEmpty(description)) {
107103
return true; //description can empty

0 commit comments

Comments
 (0)