Skip to content

Commit d9cb8b7

Browse files
authored
Merge pull request tronprotocol#3111 from M-blockcoder/develop
optimize code structure
2 parents 764e6c0 + f58394d commit d9cb8b7

File tree

3 files changed

+12
-20
lines changed

3 files changed

+12
-20
lines changed

framework/src/main/java/org/tron/core/services/http/ExchangeTransactionServlet.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,15 @@ public class ExchangeTransactionServlet extends RateLimiterServlet {
2222

2323
protected void doPost(HttpServletRequest request, HttpServletResponse response) {
2424
try {
25-
String contract = request.getReader().lines()
26-
.collect(Collectors.joining(System.lineSeparator()));
27-
Util.checkBodySize(contract);
28-
boolean visible = Util.getVisiblePost(contract);
25+
PostParams params = PostParams.getPostParams(request);
2926
ExchangeTransactionContract.Builder build = ExchangeTransactionContract.newBuilder();
30-
JsonFormat.merge(contract, build, visible);
27+
JsonFormat.merge(params.getParams(), build, params.isVisible());
3128
Transaction tx = wallet
3229
.createTransactionCapsule(build.build(), ContractType.ExchangeTransactionContract)
3330
.getInstance();
34-
JSONObject jsonObject = JSONObject.parseObject(contract);
31+
JSONObject jsonObject = JSONObject.parseObject(params.getParams());
3532
tx = Util.setTransactionPermissionId(jsonObject, tx);
36-
response.getWriter().println(Util.printCreateTransaction(tx, visible));
33+
response.getWriter().println(Util.printCreateTransaction(tx, params.isVisible()));
3734
} catch (Exception e) {
3835
Util.processError(e, response);
3936
}

framework/src/main/java/org/tron/core/services/http/GetTransactionInfoByBlockNumServlet.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -85,18 +85,14 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) {
8585

8686
protected void doPost(HttpServletRequest request, HttpServletResponse response) {
8787
try {
88-
String input = request.getReader().lines()
89-
.collect(Collectors.joining(System.lineSeparator()));
90-
Util.checkBodySize(input);
91-
boolean visible = Util.getVisiblePost(input);
92-
88+
PostParams params = PostParams.getPostParams(request);
9389
NumberMessage.Builder build = NumberMessage.newBuilder();
94-
JsonFormat.merge(input, build, visible);
90+
JsonFormat.merge(params.getParams(), build, params.isVisible());
9591

9692
long num = build.getNum();
9793
if (num > 0L) {
9894
TransactionInfoList reply = wallet.getTransactionInfoByBlockNum(num);
99-
response.getWriter().println(printTransactionInfoList(reply, visible));
95+
response.getWriter().println(printTransactionInfoList(reply, params.isVisible()));
10096
} else {
10197
response.getWriter().println("{}");
10298
}

framework/src/main/java/org/tron/core/services/http/solidity/GetTransactionInfoByIdSolidityServlet.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import org.tron.common.utils.ByteArray;
1313
import org.tron.core.Wallet;
1414
import org.tron.core.services.http.JsonFormat;
15+
import org.tron.core.services.http.PostParams;
1516
import org.tron.core.services.http.RateLimiterServlet;
1617
import org.tron.core.services.http.Util;
1718
import org.tron.protos.Protocol.TransactionInfo;
@@ -49,17 +50,15 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) {
4950
@Override
5051
protected void doPost(HttpServletRequest request, HttpServletResponse response) {
5152
try {
52-
String input = request.getReader().lines()
53-
.collect(Collectors.joining(System.lineSeparator()));
54-
Util.checkBodySize(input);
55-
boolean visible = Util.getVisiblePost(input);
53+
PostParams params = PostParams.getPostParams(request);
54+
5655
BytesMessage.Builder build = BytesMessage.newBuilder();
57-
JsonFormat.merge(input, build, visible);
56+
JsonFormat.merge(params.getParams(), build, params.isVisible());
5857
TransactionInfo transInfo = wallet.getTransactionInfoById(build.build().getValue());
5958
if (transInfo == null) {
6059
response.getWriter().println("{}");
6160
} else {
62-
response.getWriter().println(JsonFormat.printToString(transInfo, visible));
61+
response.getWriter().println(JsonFormat.printToString(transInfo, params.isVisible()));
6362
}
6463
} catch (Exception e) {
6564
logger.debug("Exception: {}", e.getMessage());

0 commit comments

Comments
 (0)