Skip to content

Commit 2a40b8d

Browse files
committed
Update prodcut name used in MSI installer.
1 parent 5d998fb commit 2a40b8d

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

packaging/WiX/CMakeLists.txt

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Copyright (c) 2010, 2023, Oracle and/or its affiliates.
2-
#
2+
#
33
# This program is free software; you can redistribute it and/or modify
44
# it under the terms of the GNU General Public License, version 2.0,
55
# as published by the Free Software Foundation.
@@ -26,7 +26,7 @@ cmake_minimum_required(VERSION 3.0)
2626
# Build MSI package from files installed in CMAKE_INSTALL_PREFIX location.
2727
#
2828
# Usage:
29-
# cmake -D CMAKE_INSTALL_PREFIX=<install loc>
29+
# cmake -D CMAKE_INSTALL_PREFIX=<install loc>
3030
# -D INSTALL_MANIFEST=<manifest file> ... <src>/packaging/WiX
3131
# cmake --build . --target MSI
3232
# cmake --build . --target ZIP
@@ -134,13 +134,17 @@ include(${BASE_DIR}/packaging/PackageSpecs.cmake)
134134
#
135135

136136
SET(MANUFACTURER "Oracle Corporation")
137-
SET(PRODUCT_NAME "MySQL Connector C++")
138-
SET(PRODUCT_DESCRIPTION "MySQL Connector C++")
137+
SET(PRODUCT_NAME "MySQL Connector/C++")
138+
SET(PRODUCT_DESCRIPTION "MySQL Connector/C++")
139139

140140
set(MAJOR_VERSION ${CONCPP_VERSION_MAJOR})
141141
set(MINOR_VERSION ${CONCPP_VERSION_MINOR})
142142
set(PATCH_VERSION ${CONCPP_VERSION_MICRO})
143143

144+
set(WIX_INSTALL_BASE "MySQL Connector C++")
145+
set(WIX_INSTALL_DIR "${WIX_INSTALL_BASE} ${MAJOR_VERSION}.${MINOR_VERSION}")
146+
147+
144148
# **** IMPORTANT ****
145149
#
146150
# The code below needs to be replaced when moving from one version
@@ -233,7 +237,7 @@ include(wix_setup.cmake)
233237
set(EXTRA_WIX_ARGS $ENV{EXTRA_WIX_ARGS})
234238

235239
add_custom_target(MSI
236-
COMMAND ${WIX_EXECUTABLE} build -ext WixToolset.UI.wixext -ext WixToolset.Util.wixext -arch ${PLATFORM} connector-cpp.wxs
240+
COMMAND ${WIX_EXECUTABLE} build -ext WixToolset.UI.wixext -ext WixToolset.Util.wixext -arch ${PLATFORM} connector-cpp.wxs
237241
-out ${CMAKE_BINARY_DIR}/${CPACK_PACKAGE_FILE_NAME}.msi
238242
${EXTRA_WIX_ARGS}
239243
)

packaging/WiX/connector-cpp.wxs.in

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@
115115
<WixVariable Id="WixUILicenseRtf" Value="@LICENSE_RTF@" />
116116

117117
<!-- Installation root-->
118-
118+
119119

120120
<!-- WIX_FEATURES -->
121121
<Feature Id="XDEVAPI" Title="New X DevAPI connector" Description="New X DevAPI connector" ConfigurableDirectory="INSTALLDIR" Level="1">
@@ -146,7 +146,7 @@
146146
<ComponentGroupRef Id="componentgroup.Readme" />
147147
</Feature>
148148

149-
<!--
149+
<!--
150150
Register installed connector in the CMake system package registry.
151151
See https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#system-package-registry
152152
-->
@@ -157,7 +157,7 @@
157157
Directory="INSTALLDIR"
158158
>
159159

160-
<RegistryValue
160+
<RegistryValue
161161
Root="HKLM"
162162
Key="Software\Kitware\CMake\Packages\mysql-concpp"
163163
Type="string"
@@ -181,7 +181,7 @@
181181

182182
<Directory Id="@PROGRAM_FILES_FOLDER@">
183183
<Directory Id="directory.MySQL" Name="MySQL">
184-
<Directory Id="INSTALLDIR" Name="@PRODUCT_NAME@ @MAJOR_VERSION@.@MINOR_VERSION@">
184+
<Directory Id="INSTALLDIR" Name="@WIX_INSTALL_DIR@">
185185
</Directory>
186186
</Directory>
187187
</Directory>

0 commit comments

Comments
 (0)