refactor(ListWrapper): drop forEach and removeLast

Closes angular#4584

Author: vicb

modules/angular2/src/core/change_detection/parser/ast.ts

@@ -221,7 +221,7 @@ export class RecursiveAstVisitor implements AstVisitor {
     return this.visitAll(ast.args);
   }
   visitAll(asts: AST[]): any {
-    ListWrapper.forEach(asts, (ast) => { ast.visit(this); });
+    asts.forEach(ast => ast.visit(this));
     return null;
   }
 }

modules/angular2/src/core/compiler/selector.ts

@@ -139,8 +139,7 @@ export class CssSelector {
         res += ']';
       }
     }
-    ListWrapper.forEach(this.notSelectors,
-                        (notSelector) => { res += ":not(" + notSelector.toString() + ")"; });
+    this.notSelectors.forEach(notSelector => res += `:not(${notSelector})`);
     return res;
   }
 }

modules/angular2/src/core/compiler/url_resolver.ts

@@ -213,7 +213,7 @@ function _removeDotSegments(path: string): string {
   var trailingSlash = path[path.length - 1] === '/' ? '/' : '';
   var segments = path.split('/');
 
-  var out = [];
+  var out: string[] = [];
   var up = 0;
   for (var pos = 0; pos < segments.length; pos++) {
     var segment = segments[pos];
@@ -223,7 +223,7 @@ function _removeDotSegments(path: string): string {
         break;
       case '..':
         if (out.length > 0) {
-          ListWrapper.removeAt(out, out.length - 1);
+          out.pop();
         } else {
           up++;
         }
@@ -235,7 +235,7 @@ function _removeDotSegments(path: string): string {
 
   if (leadingSlash == '') {
     while (up-- > 0) {
-      ListWrapper.insert(out, 0, '..');
+      out.unshift('..');
     }
 
     if (out.length === 0) out.push('.');

modules/angular2/src/core/compiler/xhr_mock.ts

@@ -28,8 +28,7 @@ export class MockXHR extends XHR {
     }
 
     do {
-      var request = ListWrapper.removeAt(this._requests, 0);
-      this._processRequest(request);
+      this._processRequest(this._requests.shift());
     } while (this._requests.length > 0);
 
     this.verifyNoOustandingExpectations();

modules/angular2/src/core/debug/debug_element.ts

@@ -126,9 +126,8 @@ export class DebugElement {
 
         var views = view.viewContainers[view.elementOffset + i];
         if (isPresent(views)) {
-          ListWrapper.forEach(views.views, (nextView) => {
-            els = els.concat(this._getChildElements(nextView, null));
-          });
+          views.views.forEach(
+              (nextView) => { els = els.concat(this._getChildElements(nextView, null)); });
         }
       }
     }
@@ -155,17 +154,15 @@ export class Scope {
     var scope = [];
     scope.push(debugElement);
 
-    ListWrapper.forEach(debugElement.children,
-                        (child) => { scope = scope.concat(Scope.all(child)); });
+    debugElement.children.forEach(child => scope = scope.concat(Scope.all(child)));
 
-    ListWrapper.forEach(debugElement.componentViewChildren,
-                        (child) => { scope = scope.concat(Scope.all(child)); });
+    debugElement.componentViewChildren.forEach(child => scope = scope.concat(Scope.all(child)));
 
     return scope;
   }
   static light(debugElement: DebugElement): DebugElement[] {
     var scope = [];
-    ListWrapper.forEach(debugElement.children, (child) => {
+    debugElement.children.forEach(child => {
       scope.push(child);
       scope = scope.concat(Scope.light(child));
     });
@@ -175,7 +172,7 @@ export class Scope {
   static view(debugElement: DebugElement): DebugElement[] {
     var scope = [];
 
-    ListWrapper.forEach(debugElement.componentViewChildren, (child) => {
+    debugElement.componentViewChildren.forEach(child => {
       scope.push(child);
       scope = scope.concat(Scope.light(child));
     });

modules/angular2/src/core/di/binding.ts

@@ -498,10 +498,10 @@ function _createListOfBindings(flattenedBindings: Map<number, any>): any[] {
   return MapWrapper.values(flattenedBindings);
 }
 
-function _normalizeBindings(bindings: Array<Type | Binding | any[]>,
+function _normalizeBindings(bindings: Array<Type | Binding | BindingBuilder | any[]>,
                             res: Map<number, _NormalizedBinding | _NormalizedBinding[]>):
     Map<number, _NormalizedBinding | _NormalizedBinding[]> {
-  ListWrapper.forEach(bindings, (b) => {
+  bindings.forEach(b => {
     if (b instanceof Type) {
       _normalizeBinding(bind(b).toClass(b), res);
 

modules/angular2/src/core/directives/ng_class.ts

@@ -9,11 +9,7 @@ import {
   KeyValueDiffers
 } from 'angular2/src/core/change_detection';
 import {Renderer} from 'angular2/src/core/render';
-import {
-  ListWrapper,
-  StringMapWrapper,
-  isListLikeIterable
-} from 'angular2/src/core/facade/collection';
+import {StringMapWrapper, isListLikeIterable} from 'angular2/src/core/facade/collection';
 
 /**
  * Adds and removes CSS classes based on an {expression} value.
@@ -109,14 +105,13 @@ export class NgClass implements DoCheck, OnDestroy {
   }
 
   private _applyInitialClasses(isCleanup: boolean) {
-    ListWrapper.forEach(this._initialClasses,
-                        (className) => { this._toggleClass(className, !isCleanup); });
+    this._initialClasses.forEach(className => this._toggleClass(className, !isCleanup));
   }
 
   private _applyClasses(rawClassVal, isCleanup: boolean) {
     if (isPresent(rawClassVal)) {
       if (isListLikeIterable(rawClassVal)) {
-        ListWrapper.forEach(rawClassVal, (className) => this._toggleClass(className, !isCleanup));
+        (<string[]>rawClassVal).forEach(className => this._toggleClass(className, !isCleanup));
       } else {
         StringMapWrapper.forEach(rawClassVal, (expVal, className) => {
           if (expVal) this._toggleClass(className, !isCleanup);

modules/angular2/src/core/dom/browser_adapter.ts

@@ -165,9 +165,7 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter {
     return node;
   }
   insertBefore(el, node) { el.parentNode.insertBefore(node, el); }
-  insertAllBefore(el, nodes) {
-    ListWrapper.forEach(nodes, (n) => { el.parentNode.insertBefore(n, el); });
-  }
+  insertAllBefore(el, nodes) { nodes.forEach(n => el.parentNode.insertBefore(n, el)); }
   insertAfter(el, node) { el.parentNode.insertBefore(node, el.nextSibling); }
   setInnerHTML(el, value) { el.innerHTML = value; }
   getText(el): string { return el.textContent; }

modules/angular2/src/core/dom/parse5_adapter.ts

@@ -222,9 +222,7 @@ export class Parse5DomAdapter extends DomAdapter {
     this.remove(node);
     treeAdapter.insertBefore(el.parent, node, el);
   }
-  insertAllBefore(el, nodes) {
-    ListWrapper.forEach(nodes, (n) => { this.insertBefore(el, n); });
-  }
+  insertAllBefore(el, nodes) { nodes.forEach(n => this.insertBefore(el, n)); }
   insertAfter(el, node) {
     if (el.nextSibling) {
       this.insertBefore(el.nextSibling, node);

modules/angular2/src/core/facade/collection.dart

@@ -125,9 +125,6 @@ class ListWrapper {
   static find(List list, bool fn(item)) =>
       list.firstWhere(fn, orElse: () => null);
   static bool any(List list, bool fn(item)) => list.any(fn);
-  static void forEach(Iterable list, fn(item)) {
-    list.forEach(fn);
-  }
 
   static void forEachWithIndex(List list, fn(item, index)) {
     for (var i = 0; i < list.length; ++i) {
@@ -160,7 +157,6 @@ class ListWrapper {
     }
   }
 
-  static removeLast(List list) => list.removeLast();
   static bool remove(List list, item) => list.remove(item);
   static void clear(List l) {
     l.clear();