eventual consistency fix for monitoring tests (GoogleCloudPlatform#413)

Author: bshaffer

monitoring/test/monitoringTest.php

@@ -46,7 +46,6 @@ public function testCreateMetric()
         $this->assertContains(self::$metricId, $output);
 
         // ensure the metric gets created
-        $this->eventuallyConsistentRetryCount = 20;
         $this->runEventuallyConsistentTest(function () {
             $output = $this->runCommand('get-descriptor', [
                 'metric_id' => self::$metricId,
@@ -64,14 +63,14 @@ public function testGetDescriptor()
         $this->assertContains(self::$metricId, $output);
     }
 
-    /** @depends testCreateMetric */
+    /** @depends testGetDescriptor */
     public function testListDescriptors()
     {
         $output = $this->runCommand('list-descriptors');
         $this->assertContains(self::$metricId, $output);
     }
 
-    /** @depends testCreateMetric */
+    /** @depends testListDescriptors */
     public function testDeleteMetric()
     {
         $output = $this->runCommand('delete-metric', [
@@ -132,10 +131,15 @@ private function runCommand($commandName, $args = [])
         $commandTester = new CommandTester($command);
 
         ob_start();
-        $commandTester->execute(
-            ['project_id' => self::$projectId] + $args,
-            ['interactive' => false]);
-
+        try {
+            $commandTester->execute(
+                ['project_id' => self::$projectId] + $args,
+                ['interactive' => false]);
+        } catch (\Google\GAX\Exception $e) {
+            // if the command throws an error cast it as a string (as this would be the output)
+            $application->renderException($e, $commandTester->getOutput());
+            return $commandTester->getDisplay();
+        }
         return ob_get_clean();
     }
 }