Bug #28047970 - WARNINGS NOT BEING VISIBLE AS THEY SHOULD BE

When warnings are accessed, complete server reply is processed and results are stored in the cache.

Author: rsomla1

common/result.h

@@ -1137,6 +1137,7 @@ inline
 unsigned Result_impl::get_warning_count() const
 {
   auto self = const_cast<Result_impl*>(this);
+  self->store_all_results();
   return self->entry_count(cdk::api::Severity::WARNING);
 }
 

devapi/result.cc

@@ -542,6 +542,7 @@ auto Result_detail::get_warning(size_t pos) -> Warning
   if (!common::check_num_limits<unsigned>(pos))
     throw std::out_of_range("No diagnostic entry at position ...");
 
+  get_warning_count();
   auto &impl = get_impl();
   auto &it = impl.get_entries(cdk::api::Severity::WARNING);
   size_t curr = SIZE_MAX;

devapi/tests/first-t.cc

@@ -565,56 +565,68 @@ TEST_F(First, warnings_multi_rset)
 
   mysqlx::Session &sess = get_sess();
 
-  sess.createSchema("test", true);
+  get_sess().createSchema("test", true);
 
-  sess.sql("DROP PROCEDURE IF EXISTS test.Get").execute();
+  sql("DROP PROCEDURE IF EXISTS test.p");
 
-  sess.sql("CREATE PROCEDURE test.Get()"\
-           "BEGIN"\
-           "  SELECT 1/0;"\
-           "  SELECT 1/0;"\
-           "END"
-           )
-      .execute();
+  sql(
+    "CREATE PROCEDURE test.p()"
+    "BEGIN"
+    "  SELECT 1;"
+    "  SELECT 1/0;"
+    "  SELECT 2/'a';"
+    "END"
+  );
 
+  {
+    SqlResult res = sql("call test.p()");
 
-  SqlResult res = sess.sql("call test.Get()").execute();
+    std::vector<Row> rows = res.fetchAll();
 
-  std::vector<Row> rows = res.fetchAll();
+    /*
+      We are in the middle of processing query result (only
+      1st rset has been consumed).
+    */
 
-  /*
-    We are in the middle of processing query result (only
-    1st rset has been consumed. Thus getWarnings() might not
-    report all the warnings yet. The protocol does not specify
-    when during result transfer the warnings will be reported.
-  */
+    EXPECT_EQ(2, res.getWarningsCount());
 
-  EXPECT_NO_THROW(res.getWarningsCount());
-  EXPECT_NO_THROW(res.getWarnings());
+    std::vector<Warning> warnings = res.getWarnings();
+    EXPECT_EQ(2, warnings.size());
 
-  res.nextResult();
+    for(auto warn : warnings)
+    {
+      std::cout << warn << std::endl;
+    }
+  }
 
-  rows = res.fetchAll();
+  {
+    // getWarnings() without getWarningsCount()
 
-  /*
-    We have consumed whole query results so all warnings
-    should be available now.
-  */
+    SqlResult res = sql("call test.p()");
 
-  std::vector<Warning> warnings = res.getWarnings();
+    unsigned cnt = 0;
+    for (Warning warn : res.getWarnings())
+    {
+      std::cout << warn << std::endl;
+      cnt++;
+    }
+    EXPECT_EQ(2, cnt);
 
-  // Bug #28047970
-  SKIP_TEST("Bug #28047970");
+    // Check that results are still available.
 
-  EXPECT_EQ(1, warnings.size());
-  EXPECT_EQ(1, res.getWarningsCount());
+    EXPECT_EQ(1, res.fetchOne()[0].get<int>());
+  }
 
-  for(auto warn : warnings)
   {
-    std::cout << warn << std::endl;
+    // getWarning() without getWarningsCount()
+
+    SqlResult res = sql("call test.p()");
+
+    EXPECT_NE(0, res.getWarning(0).getCode());
   }
 }
 
+
 TEST_F(First, parser_xplugin)
 {
 

include/mysqlx/devapi/detail/result.h

@@ -160,7 +160,7 @@ class PUBLIC_API Result_detail
 
   WarningList get_warnings()
   {
-    assert(m_impl);
+    get_warning_count();
     return { *this };
   }
 

xapi/tests/xapi-t.cc

@@ -221,6 +221,7 @@ TEST_F(xapi, compression_test_doc)
   mysqlx_session_close(sess);
 }
 
+
 TEST_F(xapi, free_test)
 {
   SKIP_IF_NO_XPLUGIN
@@ -656,9 +657,6 @@ TEST_F(xapi, warnings_test)
   /* All rows have to be read before getting warnings */
   mysqlx_store_result(res, NULL);
 
-  // Bug #28047970
-  SKIP_TEST("Bug #28047970");
-
   EXPECT_EQ(7, mysqlx_result_warning_count(res));
   warn_count = 0;
   while ((warn = mysqlx_result_next_warning(res)) != NULL)