Skip to content

Commit 623911e

Browse files
committed
Bugfix: Macro INTERNAL conflict with gRPC header status contant defintion.
In grpc/include/grpcpp/impl/codegen/status_code_enum.h , enum StatusCode 117- /// Internal errors. Means some invariants expected by underlying System has 118- /// been broken. If you see one of these errors, Something is very broken. 119: INTERNAL = 13, Replace Macro INTERNAL with INTERNAL_API will solve this conflict.
1 parent 3b942c8 commit 623911e

File tree

6 files changed

+13
-13
lines changed

6 files changed

+13
-13
lines changed

include/mysqlx/common/api.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -165,16 +165,16 @@ MYSQLX_ABI_END(2,0)
165165

166166
#if defined CONCPP_BUILD_SHARED
167167
#define PUBLIC_API DLL_EXPORT
168-
#define INTERNAL DLL_LOCAL
168+
#define INTERNAL_API DLL_LOCAL
169169
#elif defined CONCPP_BUILD_STATIC
170170
#define PUBLIC_API
171-
#define INTERNAL
171+
#define INTERNAL_API
172172
#elif !defined STATIC_CONCPP
173173
#define PUBLIC_API DLL_IMPORT
174-
#define INTERNAL
174+
#define INTERNAL_API
175175
#else
176176
#define PUBLIC_API
177-
#define INTERNAL
177+
#define INTERNAL_API
178178
#endif
179179

180180

include/mysqlx/devapi/detail/result.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ class PUBLIC_API Column_detail
238238
friend Result_detail;
239239
friend RowResult;
240240

241-
struct INTERNAL Access;
241+
struct INTERNAL_API Access;
242242
friend Access;
243243
};
244244

include/mysqlx/devapi/detail/row.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class PUBLIC_API Row_detail
5858
{
5959
protected:
6060

61-
class INTERNAL Impl;
61+
class INTERNAL_API Impl;
6262
DLL_WARNINGS_PUSH
6363
std::shared_ptr<Impl> m_impl;
6464
DLL_WARNINGS_POP

include/mysqlx/devapi/detail/session.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ struct PUBLIC_API Client_detail
291291
common::Shared_session_pool& get_session_pool();
292292

293293

294-
struct INTERNAL Impl;
294+
struct INTERNAL_API Impl;
295295

296296
DLL_WARNINGS_PUSH
297297
Shared_client_impl m_impl = NULL;
@@ -351,7 +351,7 @@ struct PUBLIC_API Session_detail
351351
}
352352

353353

354-
struct INTERNAL Impl;
354+
struct INTERNAL_API Impl;
355355

356356
/*
357357
Note: Session implementation is shared with result objects because it
@@ -394,7 +394,7 @@ struct PUBLIC_API Session_detail
394394
return *m_impl;
395395
}
396396

397-
INTERNAL cdk::Session& get_cdk_session();
397+
INTERNAL_API cdk::Session& get_cdk_session();
398398

399399
void close();
400400

include/mysqlx/devapi/document.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,15 @@ class PUBLIC_API DbDoc
7878
{
7979
// TODO: move PUBLIC_API stuff to a detail class
8080

81-
class INTERNAL Impl;
81+
class INTERNAL_API Impl;
8282

8383
DLL_WARNINGS_PUSH
8484

8585
std::shared_ptr<Impl> m_impl;
8686

8787
DLL_WARNINGS_POP
8888

89-
INTERNAL DbDoc(const std::shared_ptr<Impl>&);
89+
INTERNAL_API DbDoc(const std::shared_ptr<Impl>&);
9090

9191
const char* get_json() const;
9292

@@ -517,7 +517,7 @@ class Value
517517
friend mysqlx::string;
518518
///@endcond IGNORE
519519

520-
struct INTERNAL Access;
520+
struct INTERNAL_API Access;
521521
friend Access;
522522
};
523523

include/mysqlx/devapi/result.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ class Column
431431
public:
432432

433433
friend RowResult;
434-
struct INTERNAL Access;
434+
struct INTERNAL_API Access;
435435
friend Access;
436436
};
437437

0 commit comments

Comments
 (0)