Skip to content

Commit 05b7cf7

Browse files
committed
WL#6391: Post-push fix.
This patch fixes two test failures: 1. dd_bootstrap_debug fails on case insensitive file systems due to an insufficient WHERE clause after the push of WL#6599, since the table table 'schemata' now will match both 'mysql.schemata' and 'information_schema.SCHEMATA'. 2. dd_schema_definition_debug_c[si] fails due to differences in the way the mysqltest works for embedded servers when it evaluates mtr commands in the test. It seems like setting the SESSION debug variable has no effect on certain commands, whereas setting the GLOBAL debug variable works.
1 parent a58bf5e commit 05b7cf7

File tree

5 files changed

+14
-8
lines changed

5 files changed

+14
-8
lines changed

mysql-test/include/dd_schema_definition_debug.inc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
use mysql;
1313

14-
SET SESSION debug= '+d,skip_dd_table_access_check';
14+
SET GLOBAL debug= '+d,skip_dd_table_access_check';
1515

1616
# The DD database id
1717
let $dd_schema_id= `SELECT id FROM schemata
@@ -80,4 +80,4 @@ eval SELECT * FROM index_column_usage
8080
WHERE index_id IN ($dd_index_ids)
8181
ORDER BY index_id, column_id;
8282

83-
SET SESSION debug= '-d,skip_dd_table_access_check';
83+
SET GLOBAL debug= '-d,skip_dd_table_access_check';

mysql-test/r/dd_bootstrap_debug.result

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,10 @@
4545
# 4.4 Connect as root.
4646
# 4.5 Verify that the modified table is present.
4747
SET SESSION debug= '+d,skip_dd_table_access_check';
48-
SELECT comment FROM mysql.tables WHERE name='schemata';
48+
SELECT t.comment FROM mysql.tables AS t, mysql.schemata AS s WHERE
49+
t.name = 'schemata' AND
50+
t.schema_id = s.id AND
51+
s.name = 'mysql';
4952
comment
5053
Altered table
5154
SET SESSION debug= '-d,skip_dd_table_access_check';

mysql-test/r/dd_schema_definition_debug_ci.result

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use mysql;
2-
SET SESSION debug= '+d,skip_dd_table_access_check';
2+
SET GLOBAL debug= '+d,skip_dd_table_access_check';
33
#
44
# Subset of definitions from tables, not including
55
# timestamps, partitioning, view definitions and
@@ -447,4 +447,4 @@ index_id ordinal_position column_id length order hidden
447447
81 1 281 8 ASC 0
448448
82 1 282 192 ASC 0
449449
83 1 283 8 ASC 0
450-
SET SESSION debug= '-d,skip_dd_table_access_check';
450+
SET GLOBAL debug= '-d,skip_dd_table_access_check';

mysql-test/r/dd_schema_definition_debug_cs.result

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use mysql;
2-
SET SESSION debug= '+d,skip_dd_table_access_check';
2+
SET GLOBAL debug= '+d,skip_dd_table_access_check';
33
#
44
# Subset of definitions from tables, not including
55
# timestamps, partitioning, view definitions and
@@ -447,4 +447,4 @@ index_id ordinal_position column_id length order hidden
447447
81 1 281 8 ASC 0
448448
82 1 282 192 ASC 0
449449
83 1 283 8 ASC 0
450-
SET SESSION debug= '-d,skip_dd_table_access_check';
450+
SET GLOBAL debug= '-d,skip_dd_table_access_check';

mysql-test/t/dd_bootstrap_debug.test

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,10 @@ connect(root_con,localhost,root,,mysql);
190190

191191
--echo # 4.5 Verify that the modified table is present.
192192
SET SESSION debug= '+d,skip_dd_table_access_check';
193-
SELECT comment FROM mysql.tables WHERE name='schemata';
193+
SELECT t.comment FROM mysql.tables AS t, mysql.schemata AS s WHERE
194+
t.name = 'schemata' AND
195+
t.schema_id = s.id AND
196+
s.name = 'mysql';
194197
SET SESSION debug= '-d,skip_dd_table_access_check';
195198

196199
--echo # 4.6 Shut server down.

0 commit comments

Comments
 (0)