Skip to content

Commit 5615b16

Browse files
committed
WL#6616 PERFORMANCE SCHEMA, INDEXES
- Fix for CLANG compiler issue - Fix in table_ews_global_by_event_name::index_next() for global_table_lock_class, global_table_io_class
1 parent a6f76cb commit 5615b16

File tree

2 files changed

+21
-29
lines changed

2 files changed

+21
-29
lines changed

storage/perfschema/pfs_column_types.cc

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -31,20 +31,20 @@ struct s_object_type_map
3131

3232
static s_object_type_map object_type_map[]=
3333
{
34-
{ OBJECT_TYPE_EVENT, C_STRING_WITH_LEN("EVENT")},
35-
{ OBJECT_TYPE_FUNCTION, C_STRING_WITH_LEN("FUNCTION")},
36-
{ OBJECT_TYPE_PROCEDURE, C_STRING_WITH_LEN("PROCEDURE")},
37-
{ OBJECT_TYPE_TABLE, C_STRING_WITH_LEN("TABLE")},
38-
{ OBJECT_TYPE_TEMPORARY_TABLE, C_STRING_WITH_LEN("TEMPORARY TABLE")},
39-
{ OBJECT_TYPE_TRIGGER, C_STRING_WITH_LEN("TRIGGER")},
40-
{ OBJECT_TYPE_GLOBAL, C_STRING_WITH_LEN("GLOBAL")},
41-
{ OBJECT_TYPE_SCHEMA, C_STRING_WITH_LEN("SCHEMA")},
42-
{ OBJECT_TYPE_COMMIT, C_STRING_WITH_LEN("COMMIT")},
43-
{ OBJECT_TYPE_USER_LEVEL_LOCK, C_STRING_WITH_LEN("USER LEVEL LOCK")},
44-
{ OBJECT_TYPE_TABLESPACE, C_STRING_WITH_LEN("TABLESPACE")},
45-
{ OBJECT_TYPE_LOCKING_SERVICE, C_STRING_WITH_LEN("LOCKING SERVICE")},
46-
{ OBJECT_TYPE_LOCKING_SERVICE, C_STRING_WITH_LEN("ACL CACHE")},
47-
{ NO_OBJECT_TYPE, C_STRING_WITH_LEN("")}
34+
{ OBJECT_TYPE_EVENT, {C_STRING_WITH_LEN("EVENT")}},
35+
{ OBJECT_TYPE_FUNCTION, {C_STRING_WITH_LEN("FUNCTION")}},
36+
{ OBJECT_TYPE_PROCEDURE, {C_STRING_WITH_LEN("PROCEDURE")}},
37+
{ OBJECT_TYPE_TABLE, {C_STRING_WITH_LEN("TABLE")}},
38+
{ OBJECT_TYPE_TEMPORARY_TABLE, {C_STRING_WITH_LEN("TEMPORARY TABLE")}},
39+
{ OBJECT_TYPE_TRIGGER, {C_STRING_WITH_LEN("TRIGGER")}},
40+
{ OBJECT_TYPE_GLOBAL, {C_STRING_WITH_LEN("GLOBAL")}},
41+
{ OBJECT_TYPE_SCHEMA, {C_STRING_WITH_LEN("SCHEMA")}},
42+
{ OBJECT_TYPE_COMMIT, {C_STRING_WITH_LEN("COMMIT")}},
43+
{ OBJECT_TYPE_USER_LEVEL_LOCK, {C_STRING_WITH_LEN("USER LEVEL LOCK")}},
44+
{ OBJECT_TYPE_TABLESPACE, {C_STRING_WITH_LEN("TABLESPACE")}},
45+
{ OBJECT_TYPE_LOCKING_SERVICE, {C_STRING_WITH_LEN("LOCKING SERVICE")}},
46+
{ OBJECT_TYPE_LOCKING_SERVICE, {C_STRING_WITH_LEN("ACL CACHE")}},
47+
{ NO_OBJECT_TYPE, {C_STRING_WITH_LEN("")}}
4848
};
4949

5050
void object_type_to_string(enum_object_type object_type,

storage/perfschema/table_ews_global_by_event_name.cc

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,7 @@ int table_ews_global_by_event_name::index_next(void)
340340
PFS_rwlock_class *rwlock_class;
341341
PFS_cond_class *cond_class;
342342
PFS_file_class *file_class;
343+
PFS_instr_class *table_class;
343344
PFS_socket_class *socket_class;
344345
PFS_instr_class *instr_class;
345346

@@ -420,27 +421,18 @@ int table_ews_global_by_event_name::index_next(void)
420421
case pos_ews_global_by_event_name::VIEW_TABLE:
421422
do
422423
{
423-
if (m_pos.m_index_2 == 1)
424+
table_class= find_table_class(m_pos.m_index_2);
425+
if (table_class)
424426
{
425-
if (m_opened_index->match(&global_table_io_class))
427+
if (m_opened_index->match(table_class))
426428
{
427-
make_table_io_row(&global_table_io_class);
429+
make_table_io_row(table_class);
428430
m_next_pos.set_after(&m_pos);
429431
return 0;
430432
}
431433
m_pos.set_after(&m_pos);
432434
}
433-
if (m_pos.m_index_2 == 2)
434-
{
435-
if (m_opened_index->match(&global_table_lock_class))
436-
{
437-
make_table_lock_row(&global_table_lock_class);
438-
m_next_pos.set_after(&m_pos);
439-
return 0;
440-
}
441-
m_pos.set_after(&m_pos);
442-
}
443-
} while (rwlock_class != NULL);
435+
} while (table_class != NULL);
444436
break;
445437
case pos_ews_global_by_event_name::VIEW_SOCKET:
446438
do
@@ -652,4 +644,4 @@ ::read_row_values(TABLE *table, unsigned char *, Field **fields,
652644
}
653645

654646
return 0;
655-
}
647+
}

0 commit comments

Comments
 (0)