Improvements for preprocessor and cmake related to compiler and platform detection

Author: Bogdan Degtyariov

cdk/cmake/DepFindProtobuf.cmake

@@ -95,6 +95,16 @@ if(CMAKE_GENERATOR_TOOLSET)
   set(set_toolset -T ${CMAKE_GENERATOR_TOOLSET})
 endif()
 
+set(set_system_name)
+if(CMAKE_SYSTEM_NAME)
+  set(set_system_name -DCMAKE_SYSTEM_NAME=${CMAKE_SYSTEM_NAME})
+endif()
+
+set(set_system_processor)
+if(CMAKE_SYSTEM_PROCESSOR)
+  set(set_system_processor -DCMAKE_SYSTEM_PROCESSOR=${CMAKE_SYSTEM_PROCESSOR})
+endif()
+
 if(NOT EXISTS "${PB_BINARY_DIR}/exports.cmake")
 
   message("==== Configuring Protobuf build using cmake generator: ${CMAKE_GENERATOR} ${set_arch} ${set_toolset}")
@@ -114,6 +124,8 @@ if(NOT EXISTS "${PB_BINARY_DIR}/exports.cmake")
       ${set_arch}
       ${set_toolset}
       ${set_build_type}
+      ${set_system_name}
+      ${set_system_processor}
       -DSTATIC_MSVCRT=${STATIC_MSVCRT}
       -DCMAKE_POSITION_INDEPENDENT_CODE=${CMAKE_POSITION_INDEPENDENT_CODE}
       -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
@@ -322,7 +334,7 @@ function(mysqlx_protobuf_generate_cpp SRCS HDRS)
     set_source_files_properties(${srcs}
       APPEND_STRING PROPERTY COMPILE_FLAGS "-w"
     )
-  ELSE(WIN32)
+  ELSEIF(MSVC)
     set_source_files_properties(${srcs}
       APPEND_STRING PROPERTY COMPILE_FLAGS
       "/W1 /wd4018 /wd4996 /wd4244 /wd4267"

cdk/extra/zlib/CMakeLists.txt

@@ -141,7 +141,7 @@ string(REGEX REPLACE ".*#define[ \t]+ZLIB_VERSION[ \t]+\"([-0-9A-Za-z.]+)\".*"
 # -------------------------------------------------------------------------
 # Disable compile warnings
 
-if(WIN32)
+if(MSVC)
 
   add_compile_options(
     /wd4996

cdk/foundation/CMakeLists.txt

@@ -94,7 +94,7 @@ target_link_libraries(cdk_foundation
 )
 
 IF(WIN32)
-  target_link_libraries(cdk_foundation PRIVATE Dnsapi)
+  target_link_libraries(cdk_foundation PRIVATE dnsapi)
 ELSEIF(NOT FREEBSD)
   target_link_libraries(cdk_foundation PRIVATE resolv)
 ENDIF()

cdk/foundation/connection_openssl.cc

@@ -49,7 +49,7 @@ POP_SYS_WARNINGS_CDK
   #pragma comment directive.
 */
 
-#ifdef _WIN32
+#ifdef _MSC_VER
   #pragma comment(lib,"ws2_32")
   #if defined(WITH_SSL)
     #if OPENSSL_VERSION_NUMBER < 0x10100000L

cdk/foundation/socket_detail.cc

@@ -73,6 +73,7 @@ namespace detail {
 
   Used for handling Winsock errors.
 */
+const error_category& winsock_error_category();
 
 class error_category_winsock : public error_category_base
 {

cdk/mysqlx/CMakeLists.txt

@@ -33,7 +33,7 @@ ADD_DEFINITIONS(-DSIZEOF_LONG=${SIZEOF_LONG} -DSIZEOF_LONG_LONG=${SIZEOF_LONG_LO
 
 # TODO: Fix compile warnings in auth_mysql41.cc
 
-if(WIN32)
+if(MSVC)
   set_property(SOURCE auth_hash.cc
     PROPERTY COMPILE_FLAGS "/W3"
   )

cdk/parser/parser.h

@@ -35,7 +35,7 @@
 #include "tokenizer.h"
 
 
-#ifdef _WIN32
+#ifdef _MSC_VER
 
  /*
  4061 = enum constant not explicitly handled by switch() case.

cdk/protobuf/CMakeLists.txt

@@ -163,7 +163,7 @@ if(APPLE)
 
 endif()
 
-if(WIN32)
+if(MSVC)
 
   add_compile_options(
     /wd4018

common/session.cc

@@ -118,7 +118,9 @@ std::string get_os_version_info(std::string &platform)
   else
   {
     PUSH_SYS_WARNINGS
+#ifdef _MSC_VER
       DISABLE_WARNING(4996)
+#endif
       if (GetVersionEx(&ver) == 0)
         ver_info << "<unknown>";
     POP_SYS_WARNINGS