Skip to content

Commit df85cd8

Browse files
author
epriestley
committed
Put PATH in $_ENV after we adjust it so ExecFuture/etc pick it up
Summary: The change to setEnv() means this may not propagate correctly in some cases. See IRC. Auditors: btrahan
1 parent 49f3ff0 commit df85cd8

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/infrastructure/env/PhabricatorEnv.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,10 @@ private static function initializeCommonEnvironment() {
108108
}
109109
putenv('PATH='.$env_path);
110110

111+
// Write this back into $_ENV, too, so ExecFuture picks it up when creating
112+
// subprocess environments.
113+
$_ENV['PATH'] = $env_path;
114+
111115
PhabricatorEventEngine::initialize();
112116

113117
$translation = PhabricatorEnv::newObjectFromConfig('translation.provider');

0 commit comments

Comments
 (0)