Skip to content

Commit 3a84753

Browse files
Merge remote-tracking branch 'origin/master' into dev
* origin/master: Revert "fix: remove global scoped css affecting all md-content elements" chore: remove codesponsor because github is a bad guy! fix: remove global scoped css affecting all md-content elements chore: remove async attribute Revert "build: generate beta 5" docs: improve drastically the initial load of documentation
2 parents 987600c + 09160fb commit 3a84753

File tree

6 files changed

+34
-79
lines changed

6 files changed

+34
-79
lines changed

build/docs/webpack.js

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,22 @@ const webpackConfig = {
133133
allChunks: true,
134134
filename: '[name].[contenthash:8].css'
135135
}),
136+
new webpack.optimize.CommonsChunkPlugin({
137+
name: 'vendor',
138+
minChunks (module) {
139+
let resource = module.resource
140+
141+
if (resource && (/\.js$/).test(resource)) {
142+
return resource.indexOf(config.nodePath) >= 0
143+
}
144+
145+
return false
146+
}
147+
}),
148+
new webpack.optimize.CommonsChunkPlugin({
149+
name: 'manifest',
150+
chunks: ['vendor']
151+
}),
136152
new webpack.BannerPlugin({
137153
banner,
138154
raw: true,
@@ -177,22 +193,6 @@ const webpackConfig = {
177193
}
178194
}),
179195
new PreloadWebpackPlugin(),
180-
new webpack.optimize.CommonsChunkPlugin({
181-
name: 'vendor',
182-
minChunks (module) {
183-
let resource = module.resource
184-
185-
if (resource && (/\.js$/).test(resource)) {
186-
return resource.indexOf(config.nodePath) >= 0
187-
}
188-
189-
return false
190-
}
191-
}),
192-
new webpack.optimize.CommonsChunkPlugin({
193-
name: 'manifest',
194-
chunks: ['vendor']
195-
}),
196196
new OptimizeCssAssetsPlugin({
197197
canPrint: false
198198
}),

docs/ads.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
<!-- Carbon Ads -->
22
<script async src="//cdn.carbonads.com/carbon.js?zoneid=1673&serve=C6AILKT&placement=vuematerialio" id="_carbonads_js"></script>
33

4-
<!-- Code Sponsor -->
5-
<div class="code-sponsor-widget">
6-
<div id="code-sponsor-widget" class="code-sponsor-widget-frame"></div>
7-
</div>
8-
<script src="https://app.codesponsor.io/scripts/Tuxp4vQN_tThtWBhF8yOtA?theme=light&amp;width=330"></script>
9-
104
<!-- Amazon Pixel -->
115
<img src="//ir-na.amazon-adsystem.com/e/ir?t=vuematerial-20&l=ur2&o=1" class="amazon-pixel" />

docs/app/components/AdManager.vue

Lines changed: 10 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,18 @@
1+
<template>
2+
<div class="carbon-ads-widget"></div>
3+
</template>
4+
15
<script>
26
export default {
37
name: 'AdManager',
4-
abstract: true,
58
data: () => ({
6-
carbonEl: null,
7-
codeSponsorEl: null
9+
carbonEl: null
810
}),
9-
render () {
10-
return null
11-
},
1211
methods: {
1312
saveAdsElements () {
1413
this.carbonEl = document.getElementById('carbonads')
15-
this.codeSponsorEl = document.querySelector('.code-sponsor-widget')
1614
17-
if (!this.carbonEl || !this.codeSponsorEl) {
15+
if (!this.carbonEl) {
1816
this.$destroy()
1917
}
2018
},
@@ -24,11 +22,11 @@
2422
const container = document.querySelector('.container')
2523
const mainContainer = document.querySelector('.main-container')
2624
const splashContainer = document.querySelector('.splash-container')
27-
const carbonAdsContainer = document.querySelector('.code-sponsor-widget')
25+
const adsContainer = document.querySelector('.carbon-ads-widget')
2826
2927
if (carbonAds && container) {
3028
if (splashContainer) {
31-
carbonAdsContainer.appendChild(carbonAds)
29+
adsContainer.appendChild(carbonAds)
3230
} else if (mainContainer) {
3331
mainContainer.insertBefore(carbonAds, mainContainer.firstChild)
3432
} else {
@@ -39,42 +37,18 @@
3937
}
4038
}, 50)
4139
},
42-
appendCodeSponsor() {
43-
const interval = window.setInterval(() => {
44-
const carbonAds = document.querySelector('.code-sponsor-widget')
45-
const container = document.querySelector('.container')
46-
const mainContainer = document.querySelector('.main-container')
47-
48-
if (carbonAds && mainContainer) {
49-
if (mainContainer) {
50-
mainContainer.appendChild(carbonAds)
51-
} else {
52-
container.appendChild(carbonAds)
53-
}
54-
55-
window.clearInterval(interval)
56-
}
57-
}, 50)
58-
},
5940
moveCarbonAdsToBody() {
6041
if (this.carbonEl) {
6142
document.body.appendChild(this.carbonEl)
6243
}
63-
},
64-
moveCodeSponsorToBody() {
65-
if (this.codeSponsorEl) {
66-
document.body.appendChild(this.codeSponsorEl)
67-
}
6844
}
6945
},
7046
mounted () {
7147
this.saveAdsElements()
7248
this.appendCarbonAds()
73-
this.appendCodeSponsor()
7449
},
7550
beforeDestroy() {
7651
this.moveCarbonAdsToBody()
77-
this.moveCodeSponsorToBody()
7852
}
7953
}
8054
</script>
@@ -86,8 +60,7 @@
8660
$ad-responsive-small: 600px;
8761
8862
@mixin ad-theme ($hue, $color) {
89-
#carbonads,
90-
.code-sponsor-widget {
63+
#carbonads {
9164
background: md-get-palette-color(grey, $hue);
9265
}
9366
@@ -212,26 +185,8 @@
212185
}
213186
}
214187
215-
.code-sponsor-widget {
216-
margin-top: 64px;
217-
padding: 10px;
218-
display: flex;
219-
justify-content: center;
220-
221-
@media (max-width: $ad-responsive-small) {
222-
align-items: center;
223-
flex-direction: column;
224-
}
225-
226-
.splash-container & {
227-
width: calc(100% + 32px);
228-
margin: 0 -16px -16px;
229-
background: #fff;
230-
}
231-
188+
.carbon-ads-widget {
232189
#carbonads {
233-
margin-left: 16px;
234-
235190
@media (max-width: $ad-responsive-small) {
236191
margin-top: 16px;
237192
margin-left: 0;

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "vue-material",
33
"description": "Material Design for Vue.js",
4-
"version": "1.0.0-beta-5",
4+
"version": "1.0.0-beta-4",
55
"license": "MIT",
66
"author": {
77
"name": "marcosmoura",

src/components/MdButton/MdButton.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@
153153
}
154154
}
155155
156-
&.md-plain.md-button:not([disabled]) {
156+
&.md-plain.md-button.md-raised:not([disabled]) {
157157
color: rgba(#000, .87);
158158
background-color: #fff;
159159

yarn.lock

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6314,6 +6314,12 @@ schema-utils@^0.3.0:
63146314
dependencies:
63156315
ajv "^5.0.0"
63166316

6317+
script-ext-html-webpack-plugin@^1.8.8:
6318+
version "1.8.8"
6319+
resolved "https://registry.yarnpkg.com/script-ext-html-webpack-plugin/-/script-ext-html-webpack-plugin-1.8.8.tgz#faa888a286ce746fcd06a5e0a9e39ed7b9d24f66"
6320+
dependencies:
6321+
debug "^3.1.0"
6322+
63176323
scss-tokenizer@^0.2.3:
63186324
version "0.2.3"
63196325
resolved "https://registry.yarnpkg.com/scss-tokenizer/-/scss-tokenizer-0.2.3.tgz#8eb06db9a9723333824d3f5530641149847ce5d1"

0 commit comments

Comments
 (0)