Skip to content

Commit 8f254e9

Browse files
committed
Revert "dnsmasq: don't point --resolv-file to default location unconditionally"
This reverts commit 78edfff. This breaks local dns resolving in case noresolv=1 as resolv.conf is not populated anymore with 127.0.0.1 as resolvfile does not equal /tmp/resolv.conf.auto anymore. Signed-off-by: Hans Dedecker <[email protected]>
1 parent c16326c commit 8f254e9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

package/network/services/dnsmasq/files/dnsmasq.init

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ dhcp_relay_add() {
533533

534534
dnsmasq_start()
535535
{
536-
local cfg="$1" disabled resolvfile
536+
local cfg="$1" disabled
537537

538538
config_get_bool disabled "$cfg" disabled 0
539539
[ "$disabled" -gt 0 ] && return 0
@@ -613,6 +613,7 @@ dnsmasq_start()
613613
config_list_foreach "$cfg" "addnhosts" append_addnhosts
614614
config_list_foreach "$cfg" "bogusnxdomain" append_bogusnxdomain
615615
append_parm "$cfg" "leasefile" "--dhcp-leasefile" "/tmp/dhcp.leases"
616+
append_parm "$cfg" "resolvfile" "--resolv-file" "/tmp/resolv.conf.auto"
616617
append_parm "$cfg" "serversfile" "--servers-file"
617618
append_parm "$cfg" "tftp_root" "--tftp-root"
618619
append_parm "$cfg" "dhcp_boot" "--dhcp-boot"
@@ -627,6 +628,7 @@ dnsmasq_start()
627628
config_get_bool readethers "$cfg" readethers
628629
[ "$readethers" = "1" -a \! -e "/etc/ethers" ] && touch /etc/ethers
629630

631+
config_get resolvfile $cfg resolvfile
630632
config_get dhcpscript $cfg dhcpscript
631633

632634
config_get leasefile $cfg leasefile "/tmp/dhcp.leases"
@@ -640,8 +642,6 @@ dnsmasq_start()
640642
[ -n "$resolvfile" -a \! -e "$resolvfile" ] && touch "$resolvfile"
641643
fi
642644

643-
[ -n "$resolvfile" ] && xappend "--resolv-file=$resolvfile"
644-
645645
config_get hostsfile "$cfg" dhcphostsfile
646646
[ -e "$hostsfile" ] && xappend "--dhcp-hostsfile=$hostsfile"
647647

0 commit comments

Comments
 (0)