Fix MSVC warning C28112

Author: dmex

phlib/basesup.c

@@ -2214,13 +2214,17 @@ PPH_STRING PhReferenceEmptyString(
     PPH_STRING string;
     PPH_STRING newString;
 
-    string = PhSharedEmptyString;
+    string = InterlockedCompareExchangePointer(
+        &PhSharedEmptyString,
+        NULL,
+        NULL
+        );
 
     if (!string)
     {
         newString = PhCreateStringEx(NULL, 0);
 
-        string = _InterlockedCompareExchangePointer(
+        string = InterlockedCompareExchangePointer(
             &PhSharedEmptyString,
             newString,
             NULL

phlib/lsasup.c

@@ -64,7 +64,7 @@ LSA_HANDLE PhGetLookupPolicyHandle(
 
     // Use the cached value if possible.
 
-    lookupPolicyHandle = cachedLookupPolicyHandle;
+    lookupPolicyHandle = InterlockedCompareExchangePointer(&cachedLookupPolicyHandle, NULL, NULL);
 
     // If there is no cached handle, open one.
 
@@ -79,7 +79,7 @@ LSA_HANDLE PhGetLookupPolicyHandle(
             // We succeeded in opening a policy handle, and since we did not have a cached handle
             // before, we will now store it.
 
-            lookupPolicyHandle = _InterlockedCompareExchangePointer(
+            lookupPolicyHandle = InterlockedCompareExchangePointer(
                 &cachedLookupPolicyHandle,
                 newLookupPolicyHandle,
                 NULL

phlib/util.c

@@ -2201,14 +2201,14 @@ PPH_STRING PhGetSystemDirectory(
 
     // Use the cached value if possible.
 
-    if (cachedSystemDirectory)
-        return PhReferenceObject(cachedSystemDirectory);
+    if (systemDirectory = InterlockedCompareExchangePointer(&cachedSystemDirectory, NULL, NULL))
+        return PhReferenceObject(systemDirectory);
 
     PhGetSystemRoot(&systemRootString);
     systemDirectory = PhConcatStringRef2(&systemRootString, &system32String);
 
     // Try to cache the value.
-    if (_InterlockedCompareExchangePointer(
+    if (InterlockedCompareExchangePointer(
         &cachedSystemDirectory,
         systemDirectory,
         NULL