Fix SAL warnings

dmex · dmex · commit 3bd31f661a0b · 2019-02-19T18:35:43.000+01:00
diff --git a/phlib/include/phutil.h b/phlib/include/phutil.h
@@ -1156,8 +1156,8 @@ BOOLEAN
 NTAPI
 PhExtractIcon(
     _In_ PWSTR FileName,
-    _In_ HICON *IconLarge,
-    _In_ HICON *IconSmall
+    _Out_opt_ HICON *IconLarge,
+    _Out_opt_ HICON *IconSmall
     );
 
 PHLIBAPI
@@ -1166,8 +1166,8 @@ NTAPI
 PhExtractIconEx(
     _In_ PWSTR FileName,
     _In_ INT IconIndex,
-    _In_ HICON *IconLarge,
-    _In_ HICON *IconSmall
+    _Out_opt_ HICON *IconLarge,
+    _Out_opt_ HICON *IconSmall
     );
 
 PHLIBAPI
diff --git a/phlib/util.c b/phlib/util.c
@@ -5427,8 +5427,8 @@ PPH_STRING PhLoadIndirectString(
 // rev from ExtractIconExW
 BOOLEAN PhExtractIcon(
     _In_ PWSTR FileName, 
-    _In_ HICON *IconLarge,
-    _In_ HICON *IconSmall
+    _Out_opt_ HICON *IconLarge,
+    _Out_opt_ HICON *IconSmall
     )
 {
     return PhExtractIconEx(FileName, 0, IconLarge, IconSmall);
@@ -5437,8 +5437,8 @@ BOOLEAN PhExtractIcon(
 BOOLEAN PhExtractIconEx(
     _In_ PWSTR FileName,
     _In_ INT IconIndex,
-    _In_ HICON *IconLarge,
-    _In_ HICON *IconSmall
+    _Out_opt_ HICON *IconLarge,
+    _Out_opt_ HICON *IconSmall
     )
 {
     static PH_INITONCE initOnce = PH_INITONCE_INIT;

Original file line number	Diff line number	Diff line change
`@@ -5427,8 +5427,8 @@ PPH_STRING PhLoadIndirectString(`
`5427`	`5427`	`// rev from ExtractIconExW`
`5428`	`5428`	`BOOLEAN PhExtractIcon(`
`5429`	`5429`	`_In_ PWSTR FileName,`
`5430`		`- _In_ HICON *IconLarge,`
`5431`		`- _In_ HICON *IconSmall`
	`5430`	`+ _Out_opt_ HICON *IconLarge,`
	`5431`	`+ _Out_opt_ HICON *IconSmall`
`5432`	`5432`	`)`
`5433`	`5433`	`{`
`5434`	`5434`	`return PhExtractIconEx(FileName, 0, IconLarge, IconSmall);`
`@@ -5437,8 +5437,8 @@ BOOLEAN PhExtractIcon(`
`5437`	`5437`	`BOOLEAN PhExtractIconEx(`
`5438`	`5438`	`_In_ PWSTR FileName,`
`5439`	`5439`	`_In_ INT IconIndex,`
`5440`		`- _In_ HICON *IconLarge,`
`5441`		`- _In_ HICON *IconSmall`
	`5440`	`+ _Out_opt_ HICON *IconLarge,`
	`5441`	`+ _Out_opt_ HICON *IconSmall`
`5442`	`5442`	`)`
`5443`	`5443`	`{`
`5444`	`5444`	`static PH_INITONCE initOnce = PH_INITONCE_INIT;`