Fix some minor issues in samples found by CodeQL (microsoft#345)

Author: BissetJ

README.md

@@ -7,7 +7,7 @@ and allows the community to support Detours using open source tools and processe
 
 Detours is compatible with the Windows NT family of 
 operating systems: Windows NT, Windows XP, Windows Server 2003, Windows 7,
-Windows 8, and Windows 10.  It cannot be used by Windows Store apps
+Windows 8, Windows 10, and Windows 11.  It cannot be used by Windows Store apps
 because Detours requires APIs not available to those applications. 
 This repo contains the source code for version 4.0.1 of Detours.
 

samples/syelog/syelog.cpp

@@ -159,7 +159,7 @@ static PCHAR do_estr(PCHAR pszOut, PCHAR pszEnd, PCSTR pszIn)
                 *pszOut++ = '0' + (c % 10);
                 *pszOut++ = ';';
             }
-            else if (c < 1000 && pszOut + 6 <= pszEnd) {
+            else if (pszOut + 6 <= pszEnd) {
                 *pszOut++ = '&';
                 *pszOut++ = '#';
                 *pszOut++ = '0' + ((c / 100) % 10);

samples/traceapi/trcapi.cpp

@@ -352,7 +352,7 @@ BOOL ProcessEnumerate()
     Syelog(SYELOG_SEVERITY_INFORMATION, "###\n");
 
     LPVOID lpvEnv = Real_GetEnvironmentStrings();
-    Syelog(SYELOG_SEVERITY_INFORMATION, "### Env= %08x [%08x %08x]\n",
+    Syelog(SYELOG_SEVERITY_INFORMATION, "### Env= %p [%p %p]\n",
            lpvEnv, ((PVOID*)lpvEnv)[0], ((PVOID*)lpvEnv)[1]);
 
     return TRUE;

samples/tracebld/trcbld.cpp

@@ -1752,7 +1752,7 @@ static PCHAR do_estr(PCHAR pszOut, PCHAR pszEnd, PCSTR pszIn)
                 *pszOut++ = '0' + (c % 10);
                 *pszOut++ = ';';
             }
-            else if (c < 1000 && pszOut + 6 <= pszEnd) {
+            else if (pszOut + 6 <= pszEnd) {
                 *pszOut++ = '&';
                 *pszOut++ = '#';
                 *pszOut++ = '0' + ((c / 100) % 10);

samples/tryman/tstman.cpp

@@ -164,16 +164,16 @@ void DumpModuleInfo(HMODULE hModule)
     }
 
     if (pinh->FileHeader.Machine == 0x8664) {
-        StringCchPrintfA(szMachine, ARRAYSIZE(szMachine), "x64", pinh->FileHeader.Machine);
+        StringCchPrintfA(szMachine, ARRAYSIZE(szMachine), "x64");
     }
     else if (pinh->FileHeader.Machine == 0x014c) {
-        StringCchPrintfA(szMachine, ARRAYSIZE(szMachine), "x86", pinh->FileHeader.Machine);
+        StringCchPrintfA(szMachine, ARRAYSIZE(szMachine), "x86");
     }
     else if (pinh->FileHeader.Machine == 0x0200) {
-        StringCchPrintfA(szMachine, ARRAYSIZE(szMachine), "i64", pinh->FileHeader.Machine);
+        StringCchPrintfA(szMachine, ARRAYSIZE(szMachine), "i64");
     }
     else if (pinh->FileHeader.Machine == 0x01c0) {
-        StringCchPrintfA(szMachine, ARRAYSIZE(szMachine), "arm", pinh->FileHeader.Machine);
+        StringCchPrintfA(szMachine, ARRAYSIZE(szMachine), "arm");
     }
     else {
         StringCchPrintfA(szMachine, ARRAYSIZE(szMachine), "%04x", pinh->FileHeader.Machine);