Skip to content

Commit 15c6115

Browse files
committed
Move CreateAndCheckArgumentsNode up
1 parent e281479 commit 15c6115

File tree

5 files changed

+148
-346
lines changed

5 files changed

+148
-346
lines changed

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cext/PythonCextCEvalBuiltins.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ static Object doGeneric(PCode code, Object globals, Object locals,
157157
@Cached SequenceNodes.GetObjectArrayNode getObjectArrayNode,
158158
@Cached CodeNodes.GetCodeSignatureNode getSignatureNode,
159159
@Cached CodeNodes.GetCodeCallTargetNode getCallTargetNode,
160-
@Cached CreateArgumentsNode.CreateAndCheckArgumentsNode createAndCheckArgumentsNode,
160+
@Cached CreateArgumentsNode createArgumentsNode,
161161
@Cached CallDispatchers.SimpleIndirectInvokeNode invoke) {
162162
Object[] defaults = readNode.readPyObjectArray(defaultValueArrayPtr, defaultValueCount);
163163
PKeyword[] kwdefaults = castKwargsNode.execute(inliningTarget, kwdefaultsWrapper);
@@ -177,7 +177,7 @@ static Object doGeneric(PCode code, Object globals, Object locals,
177177
// prepare Python frame arguments
178178
Object[] userArguments = readNode.readPyObjectArray(argumentArrayPtr, argumentCount);
179179
Signature signature = getSignatureNode.execute(inliningTarget, code);
180-
Object[] pArguments = createAndCheckArgumentsNode.execute(inliningTarget, code, userArguments, keywords, signature, null, null, defaults, kwdefaults, false);
180+
Object[] pArguments = createArgumentsNode.execute(inliningTarget, code, userArguments, keywords, signature, null, null, defaults, kwdefaults, false);
181181

182182
// set custom locals
183183
if (!(locals instanceof PNone)) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/capi/PyCFunctionWrapper.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
import com.oracle.graal.python.builtins.objects.function.PBuiltinFunction;
5353
import com.oracle.graal.python.builtins.objects.function.PKeyword;
5454
import com.oracle.graal.python.builtins.objects.function.Signature;
55-
import com.oracle.graal.python.nodes.argument.CreateArgumentsNode.CreateAndCheckArgumentsNode;
55+
import com.oracle.graal.python.nodes.argument.CreateArgumentsNode;
5656
import com.oracle.graal.python.nodes.argument.keywords.ExpandKeywordStarargsNode;
5757
import com.oracle.graal.python.nodes.argument.positional.ExecutePositionalStarargsNode;
5858
import com.oracle.graal.python.nodes.call.CallDispatchers;
@@ -201,7 +201,7 @@ static final class PyCFunctionUnaryWrapper extends PyCFunctionWrapper {
201201
Object execute(Object[] arguments,
202202
@Bind("$node") Node inliningTarget,
203203
@Cached PythonToNativeNewRefNode toNativeNode,
204-
@Cached CreateAndCheckArgumentsNode createArgsNode,
204+
@Cached CreateArgumentsNode createArgsNode,
205205
@Cached CallDispatchers.CallTargetCachedInvokeNode invokeNode,
206206
@Cached NativeToPythonNode toJavaNode,
207207
@Cached TransformExceptionToNativeNode transformExceptionToNativeNode,
@@ -259,7 +259,7 @@ Object execute(Object[] arguments,
259259
@Bind("$node") Node inliningTarget,
260260
@Cached PythonToNativeNewRefNode toNativeNode,
261261
@Cached CallDispatchers.CallTargetCachedInvokeNode invokeNode,
262-
@Cached CreateAndCheckArgumentsNode createArgsNode,
262+
@Cached CreateArgumentsNode createArgsNode,
263263
@Cached NativeToPythonNode toJavaNode,
264264
@Cached TransformExceptionToNativeNode transformExceptionToNativeNode,
265265
@Exclusive @Cached GilNode gil) throws ArityException {
@@ -327,7 +327,7 @@ Object execute(Object[] arguments,
327327
@Bind("$node") Node inliningTarget,
328328
@Cached PythonToNativeNewRefNode toNativeNode,
329329
@Cached ExecutePositionalStarargsNode posStarargsNode,
330-
@Cached CreateAndCheckArgumentsNode createArgsNode,
330+
@Cached CreateArgumentsNode createArgsNode,
331331
@Cached CallDispatchers.CallTargetCachedInvokeNode invokeNode,
332332
@Cached NativeToPythonNode toJavaNode,
333333
@Cached TransformExceptionToNativeNode transformExceptionToNativeNode,
@@ -390,7 +390,7 @@ Object execute(Object[] arguments,
390390
@Bind("$node") Node inliningTarget,
391391
@Cached PythonToNativeNewRefNode toNativeNode,
392392
@Cached ExecutePositionalStarargsNode posStarargsNode,
393-
@Cached CreateAndCheckArgumentsNode createArgsNode,
393+
@Cached CreateArgumentsNode createArgsNode,
394394
@Cached CallDispatchers.CallTargetCachedInvokeNode invokeNode,
395395
@Cached ExpandKeywordStarargsNode expandKwargsNode,
396396
@Cached NativeToPythonNode toJavaNode,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/type/slots/TpSlotVarargs.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
import com.oracle.graal.python.builtins.objects.type.slots.TpSlotDescrGet.CallSlotDescrGet;
7979
import com.oracle.graal.python.nodes.ErrorMessages;
8080
import com.oracle.graal.python.nodes.PRaiseNode;
81-
import com.oracle.graal.python.nodes.argument.CreateArgumentsNode.CreateAndCheckArgumentsNode;
81+
import com.oracle.graal.python.nodes.argument.CreateArgumentsNode;
8282
import com.oracle.graal.python.nodes.call.BoundDescriptor;
8383
import com.oracle.graal.python.nodes.call.CallDispatchers;
8484
import com.oracle.graal.python.nodes.call.CallNode;
@@ -244,7 +244,7 @@ static Object callCachedBuiltin(VirtualFrame frame, Node inliningTarget, @Suppre
244244
@Specialization(replaces = "callCachedBuiltin")
245245
@InliningCutoff
246246
static Object callGenericBuiltin(VirtualFrame frame, Node inliningTarget, TpSlotVarargsBuiltin<?> slot, Object self, Object[] args, PKeyword[] keywords,
247-
@Cached CreateAndCheckArgumentsNode createArgumentsNode,
247+
@Cached CreateArgumentsNode createArgumentsNode,
248248
@Cached CallDispatchers.SimpleIndirectInvokeNode invoke) {
249249
Object[] arguments = createArgumentsNode.execute(inliningTarget, slot.getName(), args, keywords, slot.getSignature(), self, null, slot.getDefaults(), slot.getKwDefaults(),
250250
false);
@@ -261,7 +261,7 @@ abstract static class DispatchVarargsBuiltinFullDirectNode extends Node {
261261

262262
@Specialization
263263
static Object call(VirtualFrame frame, Node inliningTarget, TpSlotVarargsBuiltin<?> slot, Object self, Object[] args, PKeyword[] keywords,
264-
@Cached CreateAndCheckArgumentsNode createArgumentsNode,
264+
@Cached CreateArgumentsNode createArgumentsNode,
265265
@Cached("createDirectCallNode(slot)") DirectCallNode callNode,
266266
@Cached CallDispatchers.SimpleDirectInvokeNode invoke) {
267267
CompilerAsserts.partialEvaluationConstant(slot);

0 commit comments

Comments
 (0)