Fix lint warnings

Author: yongce

baseLib/src/main/AndroidManifest.xml

@@ -1,11 +1,13 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android">
+<manifest xmlns:tools="http://schemas.android.com/tools"
+    xmlns:android="http://schemas.android.com/apk/res/android">
 
     <permission
         android:name="${applicationId}.permission.INTERNAL"
         android:description="@string/arch_perm_guard_common_desc"
         android:label="@string/arch_perm_guard_common_label"
         android:protectionLevel="signature" />
-    <uses-permission android:name="${applicationId}.permission.INTERNAL"/>
+    <uses-permission android:name="${applicationId}.permission.INTERNAL"
+        tools:ignore="SystemPermissionTypo" />
 
 </manifest>

baseLib/src/main/java/me/ycdev/android/lib/common/async/HandlerTaskExecutor.kt

@@ -3,9 +3,8 @@ package me.ycdev.android.lib.common.async
 import android.os.Handler
 import android.os.HandlerThread
 import android.os.Looper
-import androidx.annotation.NonNull
 
-open class HandlerTaskExecutor(@NonNull val taskHandler: Handler) : ITaskExecutor {
+open class HandlerTaskExecutor(val taskHandler: Handler) : ITaskExecutor {
 
     override fun postTask(task: Runnable) {
         taskHandler.post(task)

baseLib/src/main/java/me/ycdev/android/lib/common/async/TaskScheduler.kt

@@ -6,16 +6,14 @@ import android.os.Looper
 import android.os.Message
 import android.os.SystemClock
 import androidx.annotation.IntDef
-import androidx.annotation.NonNull
 import androidx.annotation.VisibleForTesting
 import me.ycdev.android.lib.common.annotation.HandlerWork
 import me.ycdev.android.lib.common.utils.DateTimeUtils
 import me.ycdev.android.lib.common.utils.Preconditions
 import timber.log.Timber
-import java.util.ArrayList
 import java.util.concurrent.atomic.AtomicInteger
 
-class TaskScheduler(@NonNull schedulerLooper: Looper, @NonNull ownerTag: String) {
+class TaskScheduler(schedulerLooper: Looper, ownerTag: String) {
     private val ownerTag: String = taskSchedulerIdGenerator.incrementAndGet().toString() + "-" + ownerTag
     private var checkInterval = DEFAULT_CHECK_INTERVAL
     private var logEnabled = false
@@ -256,7 +254,7 @@ class TaskScheduler(@NonNull schedulerLooper: Looper, @NonNull ownerTag: String)
     }
 
     @SuppressLint("HandlerLeak")
-    private inner class SchedulerHandler(@NonNull looper: Looper) : Handler(looper) {
+    private inner class SchedulerHandler(looper: Looper) : Handler(looper) {
         override fun handleMessage(msg: Message) {
             when (msg.what) {
                 MSG_ADD_TASK -> {

baseLib/src/main/java/me/ycdev/android/lib/common/packets/PacketsWorker.kt

@@ -1,5 +1,6 @@
 package me.ycdev.android.lib.common.packets
 
+import androidx.annotation.RestrictTo
 import androidx.annotation.VisibleForTesting
 import timber.log.Timber
 import java.nio.ByteBuffer
@@ -21,13 +22,9 @@ abstract class PacketsWorker(
         }
     var debugLog = false
 
-    @VisibleForTesting
+    @RestrictTo(RestrictTo.Scope.LIBRARY)
     internal var parserState = ParserState.HEADER_MAGIC
-    protected var readBuffer: ByteBuffer
-
-    init {
-        readBuffer = ByteBuffer.allocate(DEFAULT_BUFFER_SIZE).order(ByteOrder.LITTLE_ENDIAN)
-    }
+    protected var readBuffer: ByteBuffer = ByteBuffer.allocate(DEFAULT_BUFFER_SIZE).order(ByteOrder.LITTLE_ENDIAN)
 
     fun reset() {
         parserState = ParserState.HEADER_MAGIC

baseLib/src/main/java/me/ycdev/android/lib/common/packets/TinyPacketsWorker.kt

@@ -2,11 +2,8 @@ package me.ycdev.android.lib.common.packets
 
 import androidx.annotation.VisibleForTesting
 import timber.log.Timber
-import java.lang.Math.min
 import java.nio.ByteBuffer
 import java.nio.ByteOrder
-import java.util.ArrayList
-import java.util.Arrays
 import kotlin.experimental.xor
 
 /**
@@ -59,7 +56,7 @@ class TinyPacketsWorker(callback: ParserCallback) : PacketsWorker(TAG, callback)
 
         val version = calculateVersion(data.size)
         val metaInfoSize = calculateMetaInfoSize(version)
-        val packetSize = min(maxPacketSize, data.size + metaInfoSize)
+        val packetSize = kotlin.math.min(maxPacketSize, data.size + metaInfoSize)
         val dataNumber = getDataNumber()
         val dataCrc = calculateDataCrc(data)
         val packets = ArrayList<ByteArray>()
@@ -79,10 +76,10 @@ class TinyPacketsWorker(callback: ParserCallback) : PacketsWorker(TAG, callback)
         while (offset < data.size) {
             val packet: ByteArray
             if (offset + maxPacketSize < data.size) {
-                packet = Arrays.copyOfRange(data, offset, offset + maxPacketSize)
+                packet = data.copyOfRange(offset, offset + maxPacketSize)
                 offset += maxPacketSize
             } else {
-                packet = Arrays.copyOfRange(data, offset, data.size)
+                packet = data.copyOfRange(offset, data.size)
                 offset = data.size
             }
             packets.add(packet)

baseLib/src/main/java/me/ycdev/android/lib/common/utils/PackageUtils.kt

@@ -49,7 +49,6 @@ object PackageUtils {
         return appInfo.flags and FLAG_PRIVILEGED != 0
     }
 
-    @TargetApi(Build.VERSION_CODES.HONEYCOMB_MR1)
     fun isPkgStopped(appInfo: ApplicationInfo): Boolean {
         return appInfo.flags and ApplicationInfo.FLAG_STOPPED != 0
     }

jniLibDemo/src/main/AndroidManifest.xml

@@ -2,7 +2,6 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
     <application
-        android:allowBackup="false"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
         android:theme="@style/AppTheme" >