Skip to content

Commit 298e628

Browse files
authored
Merge pull request Kocal#3 from Kocal/develop
Merge build-zip.js
2 parents fbfad6d + ea3bdd7 commit 298e628

File tree

6 files changed

+62
-42
lines changed

6 files changed

+62
-42
lines changed

README.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,15 @@ $ npm install
2626
$ npm run build
2727
```
2828

29-
### `npm run build`
29+
### `npm run watch`
3030

31-
Build the extension into `dist` folder.
31+
Watch for modifications then run `npm run build`
3232

33-
### `npm run watch`
33+
### `npm run build`
3434

35-
Watch modifications then run `npm run build`
35+
Build the extension into `dist` folder.
3636

37-
### `python scripts/build-zip`
37+
### `npm run build-zip`
3838

39-
Build a zip-file following this format « `<name>`-`<version>`.zip », by reading `name` and `version` from `manifest.json` file.
39+
Build a zip file following this format `<name>-v<version>.zip`, by reading `name` and `version` from `manifest.json` file.
40+
Zip file is located in `dist-zip` folder.

template/.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
/node_modules
22
/*.log
33
/dist
4-
/zip-builds
4+
/dist-zip

template/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"author": "{{ author }}",
66
"scripts": {
77
"build": "webpack --config webpack.config.js --progress --hide-modules",
8+
"build-zip": "node scripts/build-zip.js",
89
"watch": "npm run build -- --watch"
910
},
1011
"dependencies": {
@@ -23,9 +24,10 @@
2324
"file-loader": "^0.11.2",
2425
"node-sass": "^4.5.3",
2526
"sass-loader": "^6.0.6",
26-
"vue-loader": "^12.2.2",
27+
"vue-loader": "^13.0.4",
2728
"vue-template-compiler": "^2.4.1",
2829
"webpack": "^3.3.0",
2930
"webpack-shell-plugin": "^0.5.0"
31+
"zip-folder": "^1.0.0"
3032
}
3133
}

template/scripts/build-zip.js

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
#!/usr/bin/env node
2+
3+
const fs = require('fs');
4+
const path = require('path');
5+
const zipFolder = require('zip-folder');
6+
7+
const DEST_DIR = path.join(__dirname, '../dist');
8+
const DEST_ZIP_DIR = path.join(__dirname, '../dist-zip');
9+
10+
const extractExtensionData = () => {
11+
const extPackageJson = require('../package.json');
12+
13+
return {
14+
name: extPackageJson.name,
15+
version: extPackageJson.version
16+
}
17+
};
18+
19+
const makeDestZipDirIfNotExists = () => {
20+
if(!fs.existsSync(DEST_ZIP_DIR)) {
21+
fs.mkdirSync(DEST_ZIP_DIR);
22+
}
23+
}
24+
25+
const buildZip = (src, dist, zipFilename) => {
26+
console.info(`Building ${zipFilename}...`);
27+
28+
return new Promise((resolve, reject) => {
29+
zipFolder(src, path.join(dist, zipFilename), (err) => {
30+
if(err) {
31+
reject(err);
32+
} else {
33+
resolve();
34+
}
35+
});
36+
});
37+
};
38+
39+
const main = () => {
40+
const {name, version} = extractExtensionData();
41+
const zipFilename = `${name}-v${version}.zip`;
42+
43+
makeDestZipDirIfNotExists();
44+
45+
buildZip(DEST_DIR, DEST_ZIP_DIR, zipFilename)
46+
.then(() => console.info('OK'))
47+
.catch(console.err);
48+
};
49+
50+
main();

template/scripts/build-zip.py

Lines changed: 0 additions & 33 deletions
This file was deleted.

template/webpack.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ const config = {
6565
{from: 'manifest.json', to: 'manifest.json'}
6666
]),
6767
new WebpackShellPlugin({
68-
onBuildEnd: ['bash scripts/remove-evals.sh']
68+
onBuildEnd: ['node scripts/remove-evals.js']
6969
}),
7070
]
7171
};

0 commit comments

Comments
 (0)