Skip to content

Commit 37aaaec

Browse files
rcdaileycdunn2001
authored andcommitted
Clean up cmake END*
* Clean up closing statements for if conditions, functions, macros, and other entities. Newer versions of CMake do not require you to redundantly respecify the parameters to the opening arguments.
1 parent 585446e commit 37aaaec

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

CMakeLists.txt

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ IF(NOT WIN32)
1818
SET(CMAKE_BUILD_TYPE Release CACHE STRING
1919
"Choose the type of build, options are: None Debug Release RelWithDebInfo MinSizeRel Coverage."
2020
FORCE)
21-
ENDIF(NOT CMAKE_BUILD_TYPE)
22-
ENDIF(NOT WIN32)
21+
ENDIF()
22+
ENDIF()
2323

2424
SET(DEBUG_LIBNAME_SUFFIX "" CACHE STRING "Optional suffix to append to the library name for a debug build")
2525
SET(LIB_SUFFIX "" CACHE STRING "Optional arch-dependent suffix for the library installation directory")
@@ -39,7 +39,7 @@ MARK_AS_ADVANCED( RUNTIME_INSTALL_DIR ARCHIVE_INSTALL_DIR INCLUDE_INSTALL_DIR PA
3939
# Set variable named ${VAR_NAME} to value ${VALUE}
4040
FUNCTION(set_using_dynamic_name VAR_NAME VALUE)
4141
SET( "${VAR_NAME}" "${VALUE}" PARENT_SCOPE)
42-
ENDFUNCTION(set_using_dynamic_name)
42+
ENDFUNCTION()
4343

4444
# Extract major, minor, patch from version text
4545
# Parse a version string "X.Y.Z" and outputs
@@ -55,8 +55,8 @@ MACRO(jsoncpp_parse_version VERSION_TEXT OUPUT_PREFIX)
5555
set_using_dynamic_name( "${OUPUT_PREFIX}_FOUND" TRUE )
5656
ELSE( ${VERSION_TEXT} MATCHES ${VERSION_REGEX} )
5757
set_using_dynamic_name( "${OUPUT_PREFIX}_FOUND" FALSE )
58-
ENDIF( ${VERSION_TEXT} MATCHES ${VERSION_REGEX} )
59-
ENDMACRO(jsoncpp_parse_version)
58+
ENDIF()
59+
ENDMACRO()
6060

6161
# Read out version from "version" file
6262
#FILE(STRINGS "version" JSONCPP_VERSION)
@@ -83,7 +83,7 @@ macro(UseCompilationWarningAsError)
8383
# Only enabled in debug because some old versions of VS STL generate
8484
# warnings when compiled in release configuration.
8585
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} /WX ")
86-
endif( MSVC )
86+
endif()
8787
endmacro()
8888

8989
# Include our configuration header
@@ -93,20 +93,20 @@ if ( MSVC )
9393
# Only enabled in debug because some old versions of VS STL generate
9494
# unreachable code warning when compiled in release configuration.
9595
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} /W4 ")
96-
endif( MSVC )
96+
endif()
9797

9898
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
9999
# using regular Clang or AppleClang
100100
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -Wall -Wconversion -Wshadow -Wno-sign-conversion")
101-
elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
101+
elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
102102
# using GCC
103103
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -Wall -Wconversion -Wshadow -Wextra -pedantic")
104104
# not yet ready for -Wsign-conversion
105105
endif()
106106

107107
IF(JSONCPP_WITH_WARNING_AS_ERROR)
108108
UseCompilationWarningAsError()
109-
ENDIF(JSONCPP_WITH_WARNING_AS_ERROR)
109+
ENDIF()
110110

111111
IF(JSONCPP_WITH_PKGCONFIG_SUPPORT)
112112
CONFIGURE_FILE(
@@ -115,13 +115,13 @@ IF(JSONCPP_WITH_PKGCONFIG_SUPPORT)
115115
@ONLY)
116116
INSTALL(FILES "${CMAKE_BINARY_DIR}/pkg-config/jsoncpp.pc"
117117
DESTINATION "${CMAKE_INSTALL_PREFIX}/lib${LIB_SUFFIX}/pkgconfig")
118-
ENDIF(JSONCPP_WITH_PKGCONFIG_SUPPORT)
118+
ENDIF()
119119

120120
IF(JSONCPP_WITH_CMAKE_PACKAGE)
121121
INSTALL(EXPORT jsoncpp
122122
DESTINATION ${PACKAGE_INSTALL_DIR}/jsoncpp
123123
FILE jsoncppConfig.cmake)
124-
ENDIF(JSONCPP_WITH_CMAKE_PACKAGE)
124+
ENDIF()
125125

126126
# Build the different applications
127127
ADD_SUBDIRECTORY( src )

src/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ ADD_SUBDIRECTORY(lib_json)
22
IF(JSONCPP_WITH_TESTS)
33
ADD_SUBDIRECTORY(jsontestrunner)
44
ADD_SUBDIRECTORY(test_lib_json)
5-
ENDIF(JSONCPP_WITH_TESTS)
5+
ENDIF()

src/jsontestrunner/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ IF(BUILD_SHARED_LIBS)
99
TARGET_LINK_LIBRARIES(jsontestrunner_exe jsoncpp_lib)
1010
ELSE(BUILD_SHARED_LIBS)
1111
TARGET_LINK_LIBRARIES(jsontestrunner_exe jsoncpp_lib_static)
12-
ENDIF(BUILD_SHARED_LIBS)
12+
ENDIF()
1313

1414
SET_TARGET_PROPERTIES(jsontestrunner_exe PROPERTIES OUTPUT_NAME jsontestrunner_exe)
1515

@@ -22,4 +22,4 @@ IF(PYTHONINTERP_FOUND)
2222
DEPENDS jsontestrunner_exe jsoncpp_test
2323
)
2424
ADD_CUSTOM_TARGET(jsoncpp_check DEPENDS jsoncpp_readerwriter_tests)
25-
ENDIF(PYTHONINTERP_FOUND)
25+
ENDIF()

src/lib_json/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ IF(JSONCPP_WITH_CMAKE_PACKAGE)
3737
SET(INSTALL_EXPORT EXPORT jsoncpp)
3838
ELSE(JSONCPP_WITH_CMAKE_PACKAGE)
3939
SET(INSTALL_EXPORT)
40-
ENDIF(JSONCPP_WITH_CMAKE_PACKAGE)
40+
ENDIF()
4141

4242
IF(BUILD_SHARED_LIBS)
4343
ADD_DEFINITIONS( -DJSON_DLL_BUILD )
@@ -55,7 +55,7 @@ IF(BUILD_SHARED_LIBS)
5555
TARGET_INCLUDE_DIRECTORIES( jsoncpp_lib PUBLIC
5656
$<INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}>
5757
$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/${JSONCPP_INCLUDE_DIR}>)
58-
ENDIF(NOT CMAKE_VERSION VERSION_LESS 2.8.11)
58+
ENDIF()
5959

6060
ENDIF()
6161

@@ -75,6 +75,6 @@ IF(BUILD_STATIC_LIBS)
7575
$<INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}>
7676
$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/${JSONCPP_INCLUDE_DIR}>
7777
)
78-
ENDIF(NOT CMAKE_VERSION VERSION_LESS 2.8.11)
78+
ENDIF()
7979

8080
ENDIF()

0 commit comments

Comments
 (0)