Skip to content

Commit bb16a1b

Browse files
author
epriestley
committed
Fix a possible fatal on the first push to a cluster repository
Summary: Fixes T11020. I think this resolves things -- `$new_version` (set above) should be used, not `$new_log` directly. Specifically, we would get into trouble if the initial push failed for some reason (working copy not initialized yet, commit hook rejected, etc). Test Plan: Made a bad push to a new repository. Saw it freeze before the patch and succeed afterwards. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11020 Differential Revision: https://secure.phabricator.com/D15969
1 parent 725d60e commit bb16a1b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ public function synchronizeWorkingCopyAfterWrite() {
391391
$repository_phid,
392392
$device_phid,
393393
$this->clusterWriteVersion,
394-
$new_log->getID(),
394+
$new_version,
395395
$this->clusterWriteOwner);
396396
$did_release = true;
397397
break;

0 commit comments

Comments
 (0)