Skip to content

Commit e902fc0

Browse files
committed
Move Tablet breakpoint from 768 -> 920
Summary: Bumping this up higher since two column views get extra tight fast below 900 px. This felt most correct to me, dialing it back from first attempt at 960. Mostly I don't want to ever accidentally trigger it when I'm on the 12" MacBook. Ref T10926 Test Plan: Durable Column, Workboards, Dashboards, Tasks. Reviewers: epriestley Reviewed By: epriestley Subscribers: avivey, Korvin Maniphest Tasks: T10926 Differential Revision: https://secure.phabricator.com/D15960
1 parent ed92d1d commit e902fc0

File tree

4 files changed

+30
-28
lines changed

4 files changed

+30
-28
lines changed

resources/celerity/map.php

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
*/
88
return array(
99
'names' => array(
10-
'core.pkg.css' => '204cabae',
11-
'core.pkg.js' => '9f2969e9',
10+
'core.pkg.css' => '8aeacc63',
11+
'core.pkg.js' => '437c65c2',
1212
'darkconsole.pkg.js' => 'e7393ebb',
1313
'differential.pkg.css' => '33da0633',
1414
'differential.pkg.js' => '4b7d8f19',
@@ -126,7 +126,7 @@
126126
'rsrc/css/phui/phui-box.css' => '5c8387cf',
127127
'rsrc/css/phui/phui-button.css' => 'a64a8de6',
128128
'rsrc/css/phui/phui-chart.css' => '6bf6f78e',
129-
'rsrc/css/phui/phui-crumbs-view.css' => '1a1265d4',
129+
'rsrc/css/phui/phui-crumbs-view.css' => '6b813619',
130130
'rsrc/css/phui/phui-curtain-view.css' => '7148ae25',
131131
'rsrc/css/phui/phui-document-pro.css' => '8419560b',
132132
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
@@ -367,7 +367,7 @@
367367
'rsrc/js/application/config/behavior-reorder-fields.js' => 'b6993408',
368368
'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '01774ab2',
369369
'rsrc/js/application/conpherence/behavior-drag-and-drop-photo.js' => 'cf86d16a',
370-
'rsrc/js/application/conpherence/behavior-durable-column.js' => 'c72aa091',
370+
'rsrc/js/application/conpherence/behavior-durable-column.js' => 'd3506890',
371371
'rsrc/js/application/conpherence/behavior-menu.js' => '1d45c74d',
372372
'rsrc/js/application/conpherence/behavior-pontificate.js' => '21ba5861',
373373
'rsrc/js/application/conpherence/behavior-quicksand-blacklist.js' => '7927a7d3',
@@ -477,7 +477,7 @@
477477
'rsrc/js/core/behavior-choose-control.js' => '327a00d1',
478478
'rsrc/js/core/behavior-crop.js' => 'fa0f4fc2',
479479
'rsrc/js/core/behavior-dark-console.js' => 'f411b6ae',
480-
'rsrc/js/core/behavior-device.js' => 'b5b36110',
480+
'rsrc/js/core/behavior-device.js' => 'bb1dd507',
481481
'rsrc/js/core/behavior-drag-and-drop-textarea.js' => '484a6e22',
482482
'rsrc/js/core/behavior-error-log.js' => '6882e80a',
483483
'rsrc/js/core/behavior-fancy-datepicker.js' => '568931f3',
@@ -601,7 +601,7 @@
601601
'javelin-behavior-dashboard-tab-panel' => 'd4eecc63',
602602
'javelin-behavior-day-view' => '5c46cff2',
603603
'javelin-behavior-desktop-notifications-control' => 'edd1ba66',
604-
'javelin-behavior-device' => 'b5b36110',
604+
'javelin-behavior-device' => 'bb1dd507',
605605
'javelin-behavior-differential-add-reviewers-and-ccs' => 'e10f8e18',
606606
'javelin-behavior-differential-comment-jump' => '4fdb476d',
607607
'javelin-behavior-differential-diff-radios' => 'e1ff79b1',
@@ -620,7 +620,7 @@
620620
'javelin-behavior-diffusion-pull-lastmodified' => 'f01586dc',
621621
'javelin-behavior-doorkeeper-tag' => 'e5822781',
622622
'javelin-behavior-drydock-live-operation-status' => '901935ef',
623-
'javelin-behavior-durable-column' => 'c72aa091',
623+
'javelin-behavior-durable-column' => 'd3506890',
624624
'javelin-behavior-editengine-reorder-configs' => 'd7a74243',
625625
'javelin-behavior-editengine-reorder-fields' => 'b59e1e96',
626626
'javelin-behavior-error-log' => '6882e80a',
@@ -823,7 +823,7 @@
823823
'phui-calendar-list-css' => 'c1c7f338',
824824
'phui-calendar-month-css' => '476be7e0',
825825
'phui-chart-css' => '6bf6f78e',
826-
'phui-crumbs-view-css' => '1a1265d4',
826+
'phui-crumbs-view-css' => '6b813619',
827827
'phui-curtain-view-css' => '7148ae25',
828828
'phui-document-summary-view-css' => '9ca48bdf',
829829
'phui-document-view-css' => '715aedfb',
@@ -1794,13 +1794,6 @@
17941794
'javelin-dom',
17951795
'phabricator-draggable-list',
17961796
),
1797-
'b5b36110' => array(
1798-
'javelin-behavior',
1799-
'javelin-stratcom',
1800-
'javelin-dom',
1801-
'javelin-vector',
1802-
'javelin-install',
1803-
),
18041797
'b5c256b8' => array(
18051798
'javelin-install',
18061799
'javelin-dom',
@@ -1827,6 +1820,13 @@
18271820
'javelin-install',
18281821
'javelin-workboard-card',
18291822
),
1823+
'bb1dd507' => array(
1824+
'javelin-behavior',
1825+
'javelin-stratcom',
1826+
'javelin-dom',
1827+
'javelin-vector',
1828+
'javelin-install',
1829+
),
18301830
'bcaccd64' => array(
18311831
'javelin-behavior',
18321832
'javelin-behavior-device',
@@ -1866,16 +1866,6 @@
18661866
'c587b80f' => array(
18671867
'javelin-install',
18681868
),
1869-
'c72aa091' => array(
1870-
'javelin-behavior',
1871-
'javelin-dom',
1872-
'javelin-stratcom',
1873-
'javelin-behavior-device',
1874-
'javelin-scrollbar',
1875-
'javelin-quicksand',
1876-
'phabricator-keyboard-shortcut',
1877-
'conpherence-thread-manager',
1878-
),
18791869
'c7ccd872' => array(
18801870
'phui-fontkit-css',
18811871
),
@@ -1941,6 +1931,16 @@
19411931
'd254d646' => array(
19421932
'javelin-util',
19431933
),
1934+
'd3506890' => array(
1935+
'javelin-behavior',
1936+
'javelin-dom',
1937+
'javelin-stratcom',
1938+
'javelin-behavior-device',
1939+
'javelin-scrollbar',
1940+
'javelin-quicksand',
1941+
'phabricator-keyboard-shortcut',
1942+
'conpherence-thread-manager',
1943+
),
19441944
'd4505101' => array(
19451945
'javelin-stratcom',
19461946
'javelin-install',

webroot/rsrc/css/phui/phui-crumbs-view.css

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@
2020
text-decoration: none;
2121
}
2222

23-
.device-phone .phui-crumbs-view {
23+
.device-tablet .phui-crumbs-view,
24+
.device-phone .phui-crumbs-view,
25+
.project-board-nav .phui-crumbs-view {
2426
padding-left: 8px;
2527
padding-right: 0;
2628
}

webroot/rsrc/js/application/conpherence/behavior-durable-column.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ JX.behavior('durable-column', function(config, statics) {
3333

3434
var columnWidth = (300 + margin);
3535
// This is the smallest window size where we'll enable the column.
36-
var minimumViewportWidth = (768 - margin);
36+
var minimumViewportWidth = (920 - margin);
3737

3838
var quick = JX.$('phabricator-standard-page-body');
3939

webroot/rsrc/js/core/behavior-device.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
JX.install('Device', {
1111
statics : {
1212
_device : null,
13-
_tabletBreakpoint: 768,
13+
_tabletBreakpoint: 920,
1414

1515
setTabletBreakpoint: function(width) {
1616
var self = JX.Device;

0 commit comments

Comments
 (0)