Skip to content

Commit 56cf798

Browse files
committed
fix DRY violations
1 parent d1ae97a commit 56cf798

File tree

1 file changed

+10
-44
lines changed

1 file changed

+10
-44
lines changed

src/com/loopj/android/http/FriendlyHttpResponseHandler.java

Lines changed: 10 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,11 @@ public FriendlyHttpResponseHandler(Context startContext) {
3232
context = startContext;
3333
}
3434

35-
@Override
36-
public void onFailure(Throwable e) {
37-
String errorDescription = "An unknown error occurred.";
35+
protected void alert(String msg) {
3836
AlertDialog.Builder builder = new AlertDialog.Builder(
3937
context);
4038
builder.setTitle("Alert");
41-
builder.setMessage(errorDescription);
39+
builder.setMessage(msg);
4240
builder.setPositiveButton("OK",
4341
new DialogInterface.OnClickListener() {
4442
@Override
@@ -50,6 +48,11 @@ public void onClick(DialogInterface dialog,
5048
builder.create().show();
5149
}
5250

51+
@Override
52+
public void onFailure(Throwable e) {
53+
alert("An unknown error occurred.");
54+
}
55+
5356
public void onFailure(Throwable e, JSONObject errorResponse) {
5457
String errorDescription = "An unknown error occurred.";
5558
try {
@@ -59,53 +62,16 @@ public void onFailure(Throwable e, JSONObject errorResponse) {
5962
} catch (JSONException e1) {
6063
e1.printStackTrace();
6164
}
62-
AlertDialog.Builder builder = new AlertDialog.Builder(
63-
context);
64-
builder.setTitle("Alert");
65-
builder.setMessage(errorDescription);
66-
builder.setPositiveButton("OK",
67-
new DialogInterface.OnClickListener() {
68-
@Override
69-
public void onClick(DialogInterface dialog,
70-
int which) {
71-
dialog.dismiss();
72-
}
73-
});
74-
builder.create().show();
65+
alert(errorDescription);
7566
}
7667

7768
@Override
7869
public void onFailure(Throwable e, String errorResponse) {
79-
AlertDialog.Builder builder = new AlertDialog.Builder(
80-
context);
81-
builder.setTitle("Alert");
82-
builder.setMessage(errorResponse);
83-
builder.setPositiveButton("OK",
84-
new DialogInterface.OnClickListener() {
85-
@Override
86-
public void onClick(DialogInterface dialog,
87-
int which) {
88-
dialog.dismiss();
89-
}
90-
});
91-
builder.create().show();
70+
alert(errorResponse);
9271
}
9372

9473
public void onFailure(Throwable e, JSONArray errorResponse) {
95-
String errorDescription = "An unknown error occurred.";
96-
AlertDialog.Builder builder = new AlertDialog.Builder(
97-
context);
98-
builder.setTitle("Alert");
99-
builder.setMessage(errorDescription);
100-
builder.setPositiveButton("OK",
101-
new DialogInterface.OnClickListener() {
102-
@Override
103-
public void onClick(DialogInterface dialog,
104-
int which) {
105-
dialog.dismiss();
106-
}
107-
});
108-
builder.create().show();
74+
alert("An unknown error occurred.");
10975
}
11076

11177
public void onSuccess(JSONObject response) {

0 commit comments

Comments
 (0)