Skip to content

Commit fc491fb

Browse files
committed
Toolchain: Remove check for default_lib attribute
Unfortunately the original fix doesn't hold for all targets in the online compiler. I think this is because when we override target.c_lib with target.default_lib, the default_lib isn't in the target.supported_c_libs list. Removing the default_lib patch altogether seems to work in the sense that compilation works. This may cause issues down the line if the tools inadevertently swap out the user's selected c_lib with something else. This is another problem we have to solve in a generic way which supports all use cases we want for offline and online tools. At the moment this is just a patch to get things working for mbed 6.
1 parent be8588d commit fc491fb

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

tools/toolchains/mbed_toolchain.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1097,11 +1097,6 @@ def check_c_lib_supported(self, target, toolchain):
10971097
target.c_lib is modified to have the lowercased string of its original string.
10981098
This is done to be case insensitive when validating.
10991099
"""
1100-
if hasattr(target, "default_lib"):
1101-
# Use default_lib as the c_lib attribute. This allows backwards
1102-
# compatibility with older target definitions, allowing either
1103-
# default_lib or c_lib to specify the C library to use.
1104-
target.c_lib = target.default_lib.lower()
11051100
if hasattr(target, "c_lib"):
11061101
target.c_lib = target.c_lib.lower()
11071102
if (

0 commit comments

Comments
 (0)