Skip to content

Commit 275560e

Browse files
authored
DATAES-263 - Inner Hits support.
Original PR: spring-projects#477
2 parents 8dbbc80 + 846dbea commit 275560e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/main/java/org/springframework/data/elasticsearch/core/SearchHitMapping.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,10 @@ private SearchHits<?> mapInnerDocuments(SearchHits<SearchDocument> searchHits, C
178178
ElasticsearchPersistentEntityWithNestedMetaData persistentEntityWithNestedMetaData = getPersistentEntity(
179179
mappingContext.getPersistentEntity(type), nestedMetaData);
180180

181-
List<SearchHit<Object>> convertedSearchHits = new ArrayList<>();
182-
183181
if (persistentEntityWithNestedMetaData.entity != null) {
182+
List<SearchHit<Object>> convertedSearchHits = new ArrayList<>();
184183
Class<?> targetType = persistentEntityWithNestedMetaData.entity.getType();
184+
185185
// convert the list of SearchHit<SearchDocument> to list of SearchHit<Object>
186186
searchHits.getSearchHits().forEach(searchHit -> {
187187
SearchDocument searchDocument = searchHit.getContent();
@@ -192,7 +192,7 @@ private SearchHits<?> mapInnerDocuments(SearchHits<SearchDocument> searchHits, C
192192
searchDocument.getScore(), //
193193
searchDocument.getSortValues(), //
194194
searchDocument.getHighlightFields(), //
195-
mapInnerHits(searchDocument), //
195+
searchHit.getInnerHits(), //
196196
persistentEntityWithNestedMetaData.nestedMetaData, //
197197
targetObject));
198198
});
@@ -221,9 +221,9 @@ private SearchHits<?> mapInnerDocuments(SearchHits<SearchDocument> searchHits, C
221221
*
222222
* @param persistentEntity base entity
223223
* @param nestedMetaData nested metadata
224-
* @return The found entity or null
224+
* @return A {@link ElasticsearchPersistentEntityWithNestedMetaData} containing the found entity or null together with
225+
* the {@link NestedMetaData} that has mapped field names.
225226
*/
226-
@Nullable
227227
private ElasticsearchPersistentEntityWithNestedMetaData getPersistentEntity(
228228
@Nullable ElasticsearchPersistentEntity<?> persistentEntity, @Nullable NestedMetaData nestedMetaData) {
229229

0 commit comments

Comments
 (0)