Skip to content

Commit ad63349

Browse files
committed
Merge pull request koush#242 from ey3ball/master
Expose initial http request to WebSocket handlers
2 parents e3eafe4 + ba1c1d1 commit ad63349

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

AndroidAsync/src/com/koushikdutta/async/http/server/AsyncHttpServer.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ public void addAction(String action, String regex, HttpServerRequestCallback cal
285285
}
286286

287287
public static interface WebSocketRequestCallback {
288-
public void onConnected(WebSocket webSocket, RequestHeaders headers);
288+
public void onConnected(WebSocket webSocket, AsyncHttpServerRequest request);
289289
}
290290

291291
public void websocket(String regex, final WebSocketRequestCallback callback) {
@@ -318,15 +318,11 @@ public void onRequest(final AsyncHttpServerRequest request, final AsyncHttpServe
318318
response.end();
319319
return;
320320
}
321-
callback.onConnected(createWebSocket(request, response), request.getHeaders());
321+
callback.onConnected(new WebSocketImpl(request, response), request);
322322
}
323323
});
324324
}
325325

326-
protected WebSocket createWebSocket(final AsyncHttpServerRequest request, final AsyncHttpServerResponse response) {
327-
return new WebSocketImpl(request, response);
328-
}
329-
330326
public void get(String regex, HttpServerRequestCallback callback) {
331327
addAction(AsyncHttpGet.METHOD, regex, callback);
332328
}

AndroidAsync/test/src/com/koushikdutta/async/test/WebSocketTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import com.koushikdutta.async.http.libcore.RequestHeaders;
1010
import com.koushikdutta.async.http.server.AsyncHttpServer;
1111
import com.koushikdutta.async.http.server.AsyncHttpServer.WebSocketRequestCallback;
12+
import com.koushikdutta.async.http.server.AsyncHttpServerRequest;
1213

1314
import junit.framework.TestCase;
1415

@@ -34,7 +35,7 @@ public void onCompleted(Exception ex) {
3435

3536
httpServer.websocket("/ws", new WebSocketRequestCallback() {
3637
@Override
37-
public void onConnected(final WebSocket webSocket, RequestHeaders headers) {
38+
public void onConnected(final WebSocket webSocket, AsyncHttpServerRequest request) {
3839
webSocket.setStringCallback(new StringCallback() {
3940
@Override
4041
public void onStringAvailable(String s) {

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ server.listen(5000);
216216
```java
217217
server.websocket("/live", new WebSocketRequestCallback() {
218218
@Override
219-
public void onConnected(final WebSocket webSocket, RequestHeaders headers) {
219+
public void onConnected(final WebSocket webSocket, AsyncHttpServerRequest request) {
220220
_sockets.add(webSocket);
221221
222222
//Use this to clean up any references to your websocket

0 commit comments

Comments
 (0)