Skip to content

Commit f9eb8a4

Browse files
committed
chore: add some FIXMEs to globals.d.ts.
StringMap really ought to always enforce a string key, and also ought to have an index property. This currently breaks too much code in Angular, so should be fixed in a follow up Pull Request separate from this.
1 parent d43394f commit f9eb8a4

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

modules/angular2/globals.d.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ declare type int = number;
99

1010
interface List<T> extends Array<T> {}
1111

12-
interface StringMap<K, V> extends Object {}
12+
// FIXME: K must be string!
13+
// FIXME: should have an index signature, `[k: string]: V;`
14+
interface StringMap<K, V> {}
1315

1416
interface BrowserNodeGlobal {
1517
Object: typeof Object;

0 commit comments

Comments
 (0)