pgsql: Fix ExecEvalArrayRef to pass down the old value of the array - Mailing list pgsql-committers

Log Message:
-----------
Fix ExecEvalArrayRef to pass down the old value of the array element or slice
being assigned to, in case the expression to be assigned is a FieldStore that
would need to modify that value.  The need for this was foreseen some time
ago, but not implemented then because we did not have arrays of composites.
Now we do, but the point evidently got overlooked in that patch.  Net result
is that updating a field of an array element doesn't work right, as
illustrated if you try the new regression test on an unpatched backend.
Noted while experimenting with EXPLAIN VERBOSE, which has also got some issues
in this area.

Backpatch to 8.3, where arrays of composites were introduced.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
    pgsql/src/backend/executor:
        execQual.c (r1.226.2.2 -> r1.226.2.3)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execQual.c?r1=1.226.2.2&r2=1.226.2.3)
    pgsql/src/test/regress/expected:
        arrays.out (r1.34 -> r1.34.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/arrays.out?r1=1.34&r2=1.34.2.1)
    pgsql/src/test/regress/sql:
        arrays.sql (r1.26 -> r1.26.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/arrays.sql?r1=1.26&r2=1.26.2.1)