Re: Add SPLIT PARTITION/MERGE PARTITIONS commands - Mailing list pgsql-hackers

Hi, Jiah He!

1.
 >please check the attach doc refactor for v62-0001.

Thanks for the changes, they look good (in translation).


2.
 >here ereport should be elog(ERROR...).
 >since this error should be unreachable. see check_nested_generated,
 >cookDefault.

Changed.


3.
 >"(as for LIKE and inheritances)":
 >I think you meant, “CREATE TABLE LIKE and table inheritance reject
 >whole-row check constraint, here we will do the same”.
 >maybe change to ""(as for CREATE TABLE LIKE and inheritances)".

Changed.


--
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com