pgAdmin 4 commit: Fixes for the preferences dialog - Mailing list pgadmin-hackers

Fixes for the preferences dialog
  1) Add server mode validation in the binary path.
  2) Updated preferences tree rendering to avoid using the ReactDOM render.
  3) Updated CSS for keyboard shortcuts checkbox border makes it consistent with input box border.
  4) Fixed jasmine test case and improved code coverage.
  5) Fixed SonarQube issues.
  6) Added validation to disable "Maximum column with" option if "Column sized by" option is set to "Column name" in
QueryTool -> Result grid. 
  7) Updated documentation with the latest screenshots.
  8) Correct typo in the documentation. Fixes #7261

refs #7149

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2f37f0ca51559878de73d0cc6e786e33f0e6df81
Author: Nikhil Mohite <[email protected]>

Modified Files
--------------
docs/en_US/images/preferences_browser_display.png  | Bin 180159 -> 177359 bytes
docs/en_US/images/preferences_browser_nodes.png    | Bin 117746 -> 125514 bytes
.../images/preferences_browser_properties.png      | Bin 98006 -> 98802 bytes
.../images/preferences_browser_tab_settings.png    | Bin 218830 -> 221468 bytes
docs/en_US/preferences.rst                         |   2 +-
docs/en_US/release_notes_6_8.rst                   |   3 +-
docs/en_US/search_objects.rst                      |   2 +-
.../servers/static/js/binary_path.ui.js            |   2 +
.../static/js/components/PreferencesComponent.jsx  | 286 +++++++++++----------
.../static/js/components/PreferencesTree.jsx       | 107 ++++----
web/pgadmin/preferences/static/js/preferences.js   |   8 +-
web/pgadmin/static/js/SchemaView/MappedControl.jsx |   8 +-
web/pgadmin/static/js/components/ExternalIcon.jsx  |   4 +-
.../static/js/components/FormComponents.jsx        |  25 +-
.../static/js/components/KeyboardShortcuts.jsx     |  31 ++-
web/pgadmin/static/js/components/PgTable.jsx       |   2 +-
.../static/js/components/QueryThresholds.jsx       |   1 -
.../js/components/{Themes.jsx => SelectThemes.jsx} |   4 +-
web/pgadmin/static/js/helpers/ModalProvider.jsx    |  19 +-
web/pgadmin/static/js/tree/preference_nodes.ts     |  12 +-
web/pgadmin/static/js/tree/preferences_tree.tsx    |  53 ----
.../components/KeyboardShortcuts.spec.js           |  46 ++--
.../javascript/components/QueryThreshold.spec.js   |  41 +--
.../{Themes.spec.js => SelectThemes.spec.js}       |  10 +-
24 files changed, 337 insertions(+), 329 deletions(-)