pgsql: Set the correct context (PGC_SIGHUP) for log_autovacuum, per

Lists: pgsql-committers
From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Set the correct context (PGC_SIGHUP) for log_autovacuum, per
Date: 2007-09-10 01:39:20
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

Log Message:
-----------
Set the correct context (PGC_SIGHUP) for log_autovacuum, per ITAGAKI Takahiro.
Fix grammatical errors in its description.

Modified Files:
--------------
pgsql/doc/src/sgml:
config.sgml (r1.142 -> r1.143)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/config.sgml?r1=1.142&r2=1.143)
pgsql/src/backend/utils/misc:
guc.c (r1.417 -> r1.418)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.417&r2=1.418)


From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Tom Lane" <tgl(at)postgresql(dot)org>
Cc: <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Set the correct context (PGC_SIGHUP) for log_autovacuum, per
Date: 2007-09-11 07:16:20
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers


"Tom Lane" <tgl(at)postgresql(dot)org> writes:

> Log Message:
> -----------
> Set the correct context (PGC_SIGHUP) for log_autovacuum, per ITAGAKI Takahiro.

Didn't we say we were going to change this to log_autovacuum_min_duration?
Having a GUC called log_autovacuum for which 0 means "on" and 1 means "on
sometimes" is surprising.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com


From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: "Tom Lane" <tgl(at)postgresql(dot)org>, <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Set the correct context (PGC_SIGHUP) for log_autovacuum, per
Date: 2007-09-11 11:28:07
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers


Gregory Stark <stark(at)enterprisedb(dot)com> wrote:

> Didn't we say we were going to change this to log_autovacuum_min_duration?
> Having a GUC called log_autovacuum for which 0 means "on" and 1 means "on
> sometimes" is surprising.

Hmm, how about "log_min_duration_autovacuum" ?
We have log_min_duration_statement, that behaves in the same manner.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center