summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKatja Marttila <[email protected]>2025-06-06 09:02:17 +0300
committerKatja Marttila <[email protected]>2025-06-17 09:11:30 +0300
commitf953b8fe9b68660cd434cc9c1ecf2cd51b497908 (patch)
tree1ee1d20bace498f3cd157cb536cea5c33d9c6f1c
parent6343e0913df704b6a29c6b90aa76d112394e7c1b (diff)
Fix the 'recommended size exceeded' messageHEADdev
The message was shown when the space was freed, as we were comparing unsigned and signed integers. Change-Id: I97a759d01e663837421515661e4a102d5683ee83 Reviewed-by: Arttu Tarkiainen <[email protected]>
-rw-r--r--src/libs/installer/packagemanagercore.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libs/installer/packagemanagercore.cpp b/src/libs/installer/packagemanagercore.cpp
index cf24575ae..020c897cb 100644
--- a/src/libs/installer/packagemanagercore.cpp
+++ b/src/libs/installer/packagemanagercore.cpp
@@ -3432,7 +3432,7 @@ bool PackageManagerCore::checkAvailableSpace()
qDebug().nospace() << "Cannot determine available space on device. "
"Volume descriptor: " << targetVolume.volumeDescriptor()
<< ", Mount path: " << targetVolume.mountPath() << ". Continue silently.";
- if (required < scRecommendedMaxSize)
+ if (required < 0 || required < scRecommendedMaxSize)
emit availableSpaceChanged(SpaceInfo::SpaceAvailable);
else
emit availableSpaceChanged(SpaceInfo::RecommendedSizeExceeded);
@@ -3502,7 +3502,7 @@ bool PackageManagerCore::checkAvailableSpace()
: tr("Installation will use %1 of disk space."))
.arg(humanReadableSize(requiredDiskSpace()))).simplified();
- if (required < scRecommendedMaxSize)
+ if (required < 0 || required < scRecommendedMaxSize)
emit availableSpaceChanged(SpaceInfo::SpaceAvailable);
else
emit availableSpaceChanged(SpaceInfo::RecommendedSizeExceeded);