Skip to content

Commit 75fe4e0

Browse files
committed
try fix splinter windows test; drop chromedriver-binary from [splinter]
1 parent 244fe30 commit 75fe4e0

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
os: ubuntu-20.04
4545

4646
runs-on: ${{ matrix.os }}
47-
name: "python ${{ matrix.python-version }} ${{ matrix.os }} ${{ matrix.toxenv }}"
47+
name: "${{ matrix.os }} python ${{ matrix.python-version }} ${{ matrix.toxenv }}"
4848

4949
continue-on-error: ${{ matrix.experimental }}
5050
env:

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def read(fname):
5454
python_requires=">=3.6, <4",
5555
entry_points={"pytest11": ["image_diff = pytest_image_diff.plugin"]},
5656
install_requires=["pytest", "typing_extensions", "diffimg", "imgdiff"],
57-
extras_require={"splinter": ["pytest-splinter>=2.1.0", "chromedriver-binary-auto"]},
57+
extras_require={"splinter": ["pytest-splinter>=2.1.0"]},
5858
zip_safe=False,
5959
include_package_data=True,
6060
keywords=["pytest"],

tox.ini

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,18 @@ envlist =
55
py3{6,7,8,9,10,11}
66

77
[testenv]
8+
# environment will be skipped if regular expression does not match against the sys.platform string
9+
platform = linux: linux
10+
macos: darwin
11+
windows: win32
12+
813
changedir = {toxinidir}
914
deps =
1015
-r{toxinidir}/requirements-dev.txt
1116
splinter: -e .[splinter]
17+
splinter-linux: chromedriver-binary-auto
18+
splinter-windows: chromedriver-binary==2.40.1
19+
1220
setenv =
1321
PYTHONPATH = {toxinidir}
1422
passenv =

0 commit comments

Comments
 (0)