Use StringBuilders instead of StringBuffers, close #305

Author: Stephane Landelle

src/main/java/com/ning/http/client/resumable/PropertiesBasedResumableProcessor.java

@@ -90,7 +90,7 @@ public void save(Map<String, Long> map) {
     }
 
     private static String append(Map.Entry<String, Long> e) {
-        return new StringBuffer(e.getKey()).append("=").append(e.getValue()).append("\n").toString();
+        return new StringBuilder(e.getKey()).append("=").append(e.getValue()).append("\n").toString();
     }
 
     /**

src/main/java/com/ning/http/multipart/MultipartRequestEntity.java

@@ -143,7 +143,7 @@ public String getContentType() {
         if (contentType.contains("boundary="))
             return contentType;
         else {
-            StringBuffer buffer = new StringBuffer(contentType);
+            StringBuilder buffer = new StringBuilder(contentType);
             if (!contentType.endsWith(";"))
                 buffer.append(";");
             buffer.append(" boundary=");

src/main/java/com/ning/http/util/AsyncHttpProviderUtils.java

@@ -456,7 +456,7 @@ private static void add(StringBuilder sb, String name, int val) {
     }
 
     public static String constructUserAgent(Class<? extends AsyncHttpProvider> httpProvider) {
-        StringBuffer b = new StringBuffer("AsyncHttpClient/1.0")
+        StringBuilder b = new StringBuilder("AsyncHttpClient/1.0")
                 .append(" ")
                 .append("(")
                 .append(httpProvider.getSimpleName())

src/test/java/com/ning/http/client/async/BasicAuthTest.java

@@ -474,7 +474,7 @@ public AbstractHandler configureHandler() throws Exception {
     }
 
     @Test(groups = { "standalone", "default_provider" })
-    public void StringBufferBodyConsumerTest() throws Throwable {
+    public void StringBuilderBodyConsumerTest() throws Throwable {
         SimpleAsyncHttpClient client = new SimpleAsyncHttpClient.Builder().setRealmPrincipal(user).setRealmPassword(admin).setUrl(getTargetUrl()).setHeader("Content-Type", "text/html").build();
         try {
             StringBuilder s = new StringBuilder();

src/test/java/com/ning/http/client/async/SimpleAsyncHttpClientTest.java

@@ -56,7 +56,7 @@ public void inpuStreamBodyConsumerTest() throws Throwable {
     }
 
     @Test(groups = { "standalone", "default_provider" })
-    public void StringBufferBodyConsumerTest() throws Throwable {
+    public void StringBuilderBodyConsumerTest() throws Throwable {
 
         SimpleAsyncHttpClient client = new SimpleAsyncHttpClient.Builder().setIdleConnectionInPoolTimeoutInMs(100).setMaximumConnectionsTotal(50).setRequestTimeoutInMs(5 * 60 * 1000).setUrl(getTargetUrl()).setHeader("Content-Type", "text/html").build();
         try {